From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Farhan Ali <alifm@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-fbdev@vger.kernel.org, geert@linux-m68k.org,
stefan.kristiansson@saunalahti.fi, tomi.valkeinen@ti.com,
schwidefsky@de.ibm.com, dri-devel@lists.freedesktop.org,
Chen Liqin <liqin.linux@gmail.com>,
Lennox Wu <lennox.wu@gmail.com>, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
Date: Thu, 08 Feb 2018 15:30:21 +0000 [thread overview]
Message-ID: <b93b12b9-bfcc-8ae4-ad74-fd4f262872a8@de.ibm.com> (raw)
In-Reply-To: <1610039.4trOurtpys@amdc3058>
On 02/08/2018 02:11 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> [ dri-devel ML & arch/[score,um] Maintainers added to Cc: ]
>
> On Friday, February 02, 2018 08:59:57 AM Christian Borntraeger wrote:
>> On 02/01/2018 07:41 PM, Farhan Ali wrote:
>>> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")'
>>> added the HAS_IOMEM dependecy for "Graphics support". This disabled the
>>> "Graphics support" menu for S390. But if we enable VT layer for S390,
>>> we would also need to enable the dummy console. So let's remove the
>>> HAS_IOMEM dependency.
>>>
>>> Move this dependency to Opencores framebuffer driver which would fail to build
>>> with CONFIG_HAS_IOMEM disabled:
>>>
>>> ERROR: "devm_ioremap_resource" [drivers/video/fbdev/ocfb.ko] undefined!
>
> "Graphics support" menu covers other things (i.e. DRM), I assume that
> they were also checked to not break due to this change?
>
> Moreover it seems that after this change "Graphics support" menu will
> be also enabled (besides s390) for score, tile and um architectures,
> I assume that this is okay?
I can add this patch to my next tree (after merge window) and check for
any errors from all the build bots.
next prev parent reply other threads:[~2018-02-08 15:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 18:41 [PATCH v2 0/3]Enable CONFIG_VT support for S390 Farhan Ali
2018-02-01 18:41 ` [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Farhan Ali
2018-02-02 7:59 ` Christian Borntraeger
2018-02-08 13:11 ` Bartlomiej Zolnierkiewicz
2018-02-08 15:28 ` Farhan Ali
2018-02-08 15:30 ` Christian Borntraeger [this message]
2018-02-14 8:12 ` Christian Borntraeger
2018-02-15 9:40 ` Christian Borntraeger
2018-02-15 11:02 ` Christian Borntraeger
2018-02-15 11:14 ` [PATCH] s390/console: enable dummy console for vt Christian Borntraeger
2018-02-15 11:26 ` Geert Uytterhoeven
2018-02-15 11:56 ` Christian Borntraeger
2018-02-15 11:57 ` Thomas Huth
2018-02-15 12:02 ` Christian Borntraeger
2018-02-19 13:35 ` Farhan Ali
2018-02-19 13:37 ` Christian Borntraeger
2018-02-19 14:01 ` Farhan Ali
2018-02-06 12:36 ` [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Thomas Huth
2018-02-01 18:41 ` [PATCH v2 2/3] s390/char : Rename EBCDIC keymap variables Farhan Ali
2018-02-01 18:41 ` [PATCH v2 3/3] s390/setup : enable display support for KVM guest Farhan Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b93b12b9-bfcc-8ae4-ad74-fd4f262872a8@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=jdike@addtoit.com \
--cc=lennox.wu@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=liqin.linux@gmail.com \
--cc=richard@nod.at \
--cc=schwidefsky@de.ibm.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tomi.valkeinen@ti.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).