From: Helge Deller <deller@gmx.de>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] fbdev: Switch back to struct platform_driver::remove()
Date: Tue, 8 Oct 2024 09:04:52 +0200 [thread overview]
Message-ID: <ba3303db-f51f-431d-83fe-b02306dbc8fb@gmx.de> (raw)
In-Reply-To: <7l2xan5aa4kvbzeolwdpeccnsfnp5o5zjucnibd6mdhj2abw46@y7vwlg6tnqmt>
On 10/8/24 08:58, Uwe Kleine-König wrote:
> On Tue, Oct 08, 2024 at 08:30:40AM +0200, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 07.10.24 um 18:35 schrieb Uwe Kleine-König:
>>> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
>>> return void") .remove() is (again) the right callback to implement for
>>> platform drivers.
>>>
>>> Convert all platform drivers below drivers/dma after the previous
>>> conversion commits apart from the wireless drivers to use .remove(),
>>> with the eventual goal to drop struct platform_driver::remove_new(). As
>>> .remove() and .remove_new() have the same prototypes, conversion is done
>>> by just changing the structure member name in the driver initializer.
>>
>> This paragraph refers to dma and wireless code. I don't understand how that
>> is related.
>
> Ah, too many patches and missing automation in some parts.
>
> @Helge, can you replace this paragraph by:
will do.
Thanks!
Helge
> Convert all platform drivers below drivers/video/fbdev to use .remove(),
> with the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is done
> by just changing the structure member name in the driver initializer.
>
> ? Or should I resend?
>
> Thanks for noticing,
> Uwe
prev parent reply other threads:[~2024-10-08 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 16:35 [PATCH] fbdev: Switch back to struct platform_driver::remove() Uwe Kleine-König
2024-10-07 19:44 ` Helge Deller
2024-10-08 6:30 ` Thomas Zimmermann
2024-10-08 6:58 ` Uwe Kleine-König
2024-10-08 7:04 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba3303db-f51f-431d-83fe-b02306dbc8fb@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).