From: Dan Carpenter <dan.carpenter@linaro.org>
To: Gabriel Lima Luz <lima.gabriel.luz@gmail.com>
Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH] staging: sm750fb: Fix CamelCase variable naming
Date: Fri, 28 Feb 2025 20:40:00 +0300 [thread overview]
Message-ID: <ba45d980-c6b1-482a-8bfd-457a92d3e24b@stanley.mountain> (raw)
In-Reply-To: <20250228162359.14029-1-lima.gabriel.luz@gmail.com>
On Fri, Feb 28, 2025 at 01:23:54PM -0300, Gabriel Lima Luz wrote:
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> CHECK: Avoid CamelCase
>
> Signed-off-by: Gabriel Lima Luz <lima.gabriel.luz@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_power.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h
> index 63c9e8b6ffb3..33e852fe6949 100644
> --- a/drivers/staging/sm750fb/ddk750_power.h
> +++ b/drivers/staging/sm750fb/ddk750_power.h
> @@ -3,10 +3,10 @@
> #define DDK750_POWER_H__
>
> enum dpms {
> - crtDPMS_ON = 0x0,
> - crtDPMS_STANDBY = 0x1,
> - crtDPMS_SUSPEND = 0x2,
> - crtDPMS_OFF = 0x3,
> + crt_DPMS_ON = 0x0,
> + crt_DPMS_STANDBY = 0x1,
> + crt_DPMS_SUSPEND = 0x2,
> + crt_DPMS_OFF = 0x3,
> };
>
It seems these are not used. Just delete them.
regards,
dan carpenter
next prev parent reply other threads:[~2025-02-28 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 16:23 [PATCH] staging: sm750fb: Fix CamelCase variable naming Gabriel Lima Luz
2025-02-28 17:40 ` Dan Carpenter [this message]
2025-03-06 19:40 ` Gabriel Lima Luz
2025-03-06 20:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba45d980-c6b1-482a-8bfd-457a92d3e24b@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=lima.gabriel.luz@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox