linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: [Linux-fbdev-devel] drm_fb_helper: Impossible to change video mode
Date: Fri, 20 Nov 2009 13:16:28 +0000	[thread overview]
Message-ID: <badfd5ba0911200516m55693acbp8fc5164bd6d828cf@mail.gmail.com> (raw)

Hi,

On drivers using drm_fb_helper's in fb_ops it is not possible to change
video mode, because of different var->pixclock evaluation:

int drm_fb_helper_check_var(struct fb_var_screeninfo *var,
			    struct fb_info *info)
{
[...]
	if (var->pixclock = -1 || !var->pixclock)
		return -EINVAL;
[...]

int drm_fb_helper_set_par(struct fb_info *info)
{
[...]
	if (var->pixclock != -1) {
		DRM_ERROR("PIXEL CLCOK SET\n");
		return -EINVAL;
	}
[...]

One of these evaluations will fail regardless of pixclock value.

P.S. check CLCOK spelling :)

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

             reply	other threads:[~2009-11-20 13:16 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20 13:16 Paulius Zaleckas [this message]
2009-11-20 15:55 ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video Clemens Ladisch
2009-11-20 18:53 ` James Simmons
2009-11-20 19:05 ` Andrew Morton
2009-11-20 19:39 ` Paulius Zaleckas
2009-11-20 20:01 ` James Simmons
2009-11-20 20:13 ` Paulius Zaleckas
2009-11-20 20:48 ` James Simmons
2009-11-21  4:25 ` Dave Airlie
2009-11-21  4:27 ` Dave Airlie
2010-03-01  9:18   ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video mode Michal Suchanek
2010-03-03  5:02     ` Dave Airlie
2010-03-03  8:23       ` Michal Suchanek
2010-03-03  9:23         ` Dave Airlie
2010-03-03 10:32           ` Michal Suchanek
2010-03-10 18:11             ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video James Simmons
2010-03-10 21:04               ` Ville Syrjälä
2010-03-10 21:16                 ` Michal Suchanek
2010-03-11  2:24                   ` James Simmons
2010-03-11  2:22                 ` James Simmons
2010-03-11  5:03                   ` Ville Syrjälä
2010-03-10 18:04           ` James Simmons
2010-03-10 17:42       ` James Simmons
2010-03-10 18:05         ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video mode Alex Deucher
2010-03-10 18:10           ` Alex Deucher
2010-03-10 18:47             ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video James Simmons
2010-03-10 19:49               ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video mode Michal Suchanek
2010-03-10 20:06               ` Alex Deucher
2010-03-11 10:13             ` Michel Dänzer
2010-03-11 10:31               ` Pauli Nieminen
2010-03-11 15:12               ` Alex Deucher
2010-03-11 15:17                 ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video James Simmons
2010-03-11 15:47                   ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video mode Michal Suchanek
2010-03-12 14:52                     ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video James Simmons
2010-03-12 20:51                       ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video mode Dave Airlie
2010-03-13 14:40                         ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video James Simmons
2010-03-13 21:01                           ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video mode Dave Airlie
2010-03-14 11:41                             ` Michel Dänzer
2010-03-15 18:38                               ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video James Simmons
2010-03-16 13:46                                 ` Michel Dänzer
2010-03-16 13:56                                   ` James Simmons
2010-03-16 14:00                                     ` Michel Dänzer
2010-03-25 12:30                                       ` James Simmons
2010-03-15 18:22                             ` James Simmons
2010-03-10 20:58         ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video mode Michal Suchanek
2010-03-11  3:41           ` [Linux-fbdev-devel] drm_fb_helper: Impossible to change video James Simmons
2010-03-10 17:35     ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=badfd5ba0911200516m55693acbp8fc5164bd6d828cf@mail.gmail.com \
    --to=paulius.zaleckas@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).