From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 656D5C433F5 for ; Wed, 9 Mar 2022 13:43:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231656AbiCINok (ORCPT ); Wed, 9 Mar 2022 08:44:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233288AbiCINo1 (ORCPT ); Wed, 9 Mar 2022 08:44:27 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CE268123439 for ; Wed, 9 Mar 2022 05:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646833404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DNwPCyT8wmbEfZK8P/i6Q32UvGlt9pDVFx+4Sf2sAjk=; b=SH+j8ZaidiY3ujgsXtr1hUOwLlbG1ilNMfkWt2oplXs8A4tnxU70cGauNWR9id/n+CY/AM 0SVweOq2iaCKG8MQxkBL0yXO3fMG9U0Rd2jtt62ZRUcwMZcJRmpCwT3a1LXgGS/KxZhP7t 01x2wptcVEhYji33bs04m+ZrtsCJ1OA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-157-QWK95BOmOaamk7oMpLSewA-1; Wed, 09 Mar 2022 08:43:23 -0500 X-MC-Unique: QWK95BOmOaamk7oMpLSewA-1 Received: by mail-wm1-f69.google.com with SMTP id m34-20020a05600c3b2200b0038115c73361so806030wms.5 for ; Wed, 09 Mar 2022 05:43:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=DNwPCyT8wmbEfZK8P/i6Q32UvGlt9pDVFx+4Sf2sAjk=; b=l9Z9YpPhfAcOY9Ul1Yu8CR6Ck4YHEHjgvSQP/AMRSsaYkksuxIav7wDDvkcYxtxTJM Ze2byBd5sYv7hGmxhCxEAnrt/nePVOmQWSiQhoHDZHqvnIsfqrWQFwN+yHA5rJXHUS5P b9WbgtgwAVG/PS7gidQpbFSqAOsgPhMTRYy9l2YDp97sn1ayOsdNtiZYCsdbo/KCSwfP pR4T1SBmrKcGSoEquUybwrQRU2BfZoQ7EvB7sGCfXCIu87x2PFIvfudxsn9ryeSR9d9t +9gXEsDpcXcGhfKTLWCyfm/WuhUEB5j+vkJMzuQT4GN7jzqb5tRdiHDQRsp7tCqi57JY hMJg== X-Gm-Message-State: AOAM531vdiyUgMfPGMvtg83YeP26NZlSzcC+PmNb5Ca3jO0730hoFVEi TTPR+RcQ48ocVfG6M9tCHjWAjiyryewIReBFCt/UX6RUWD+n7uZrugEiCD7FbPbgJt/0e+EDun2 e6LC1CDe5aVRdNJ8EOSAqFNs= X-Received: by 2002:a7b:c8c2:0:b0:389:9746:847c with SMTP id f2-20020a7bc8c2000000b003899746847cmr7696209wml.156.1646833402439; Wed, 09 Mar 2022 05:43:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxSJ8Ywl1f4YowLEemqy29qqclDeVGuf5169bKODTz+Q+zNq8dX3nn3Xb5FN4RwNdJP8Nhbdw== X-Received: by 2002:a7b:c8c2:0:b0:389:9746:847c with SMTP id f2-20020a7bc8c2000000b003899746847cmr7696194wml.156.1646833402233; Wed, 09 Mar 2022 05:43:22 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id p11-20020adf9d8b000000b001f063deef80sm1653234wre.86.2022.03.09.05.43.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Mar 2022 05:43:19 -0800 (PST) Message-ID: Date: Wed, 9 Mar 2022 14:43:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays Content-Language: en-US To: Geert Uytterhoeven Cc: Linux Kernel Mailing List , Linux Fbdev development list , Andy Shevchenko , Daniel Vetter , Thomas Zimmermann , Sam Ravnborg , DRI Development , Maxime Ripard , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Daniel Vetter , David Airlie , Lee Jones , Maarten Lankhorst , Maxime Ripard , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Linux PWM List References: <20220214133710.3278506-1-javierm@redhat.com> <20220214133710.3278506-4-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hello Geert, On 3/9/22 13:56, Geert Uytterhoeven wrote: > Hi Javier, > > On Wed, Mar 9, 2022 at 1:14 PM Javier Martinez Canillas > wrote: >> On 3/8/22 17:30, Geert Uytterhoeven wrote: >>> Unfortunately a regression was introduced since your v3: printed >>> text is mirrored upside-down. I.e. "E" is rendered correctly, but "L" >>> turns into "Γ" (Greek Gamma). >>> I suspect something went wrong with the display initialization >>> sequence. >>> >> >> Could you please try Chen-Yu's fix for the COM scan direction mask ? >> >> https://lists.freedesktop.org/archives/dri-devel/2022-March/345915.html >> >> I made a mistake when converting to use the GENMASK() and FIELD_PREP() >> macros in v4 as suggested by Andy. The SSD130X_SET_COM_SCAN_DIR_MASK >> wasn't correct which would explain the output to be vertically flipped. > > Thanks, confirmed fixed. > Great, thanks a lot for testing and the confirmation! -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat