From: Timur Tabi <timur@kernel.org>
To: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 21/21] fbdev: fsl-diu: get cpu node with of_get_cpu_node
Date: Tue, 11 Sep 2018 03:34:10 +0000 [thread overview]
Message-ID: <bc758dcc-c881-ab7e-129f-8a1a1c628daa@kernel.org> (raw)
In-Reply-To: <20180905193738.19325-22-robh@kernel.org>
On 9/5/18 2:37 PM, Rob Herring wrote:
> #ifdef CONFIG_NOT_COHERENT_CACHE
> - np = of_find_node_by_type(NULL, "cpu");
> + np = of_get_cpu_node(0, NULL);
This #ifdef means that it's only compiled on an MPC5121, which is a very
dead platform. of_get_cpu_node() looks okay to me, but I'm going to
have to assume that you know what you're doing.
Acked-by: Timur Tabi <timur@kernel.org>
next prev parent reply other threads:[~2018-09-11 3:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 19:37 [PATCH 00/21] DT cpu node iterator Rob Herring
2018-09-05 19:37 ` [PATCH 21/21] fbdev: fsl-diu: get cpu node with of_get_cpu_node Rob Herring
2018-09-11 3:34 ` Timur Tabi [this message]
[not found] ` <CAHTX3d+BFKM-jFo8Ww_dXwAzsDVoWqE==erfwVTeijHfh8kkOw@mail.gmail.com>
2018-09-07 13:58 ` [PATCH 00/21] DT cpu node iterator Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc758dcc-c881-ab7e-129f-8a1a1c628daa@kernel.org \
--to=timur@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).