From: Timur Tabi <timur@kernel.org>
To: Wen Yang <wen.yang99@zte.com.cn>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn
Subject: Re: [PATCH] fbdev: fsl-diu: remove redundant null check on cmap
Date: Mon, 03 Dec 2018 14:53:53 +0000 [thread overview]
Message-ID: <bda8bdc3-46cb-883d-1ddc-8fda0cf241be@kernel.org> (raw)
In-Reply-To: <20181203064317.57054-1-wen.yang99@zte.com.cn>
On 12/3/18 12:43 AM, Wen Yang wrote:
> The null check on &info->cmap is redundant since cmap is a struct
> inside fb_info and can never be null, so the check is always true.
> we may remove it.
>
> Signed-off-by: Wen Yang<wen.yang99@zte.com.cn>
Acked-by: Timur Tabi <timur@kernel.org>
next prev parent reply other threads:[~2018-12-03 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 6:43 [PATCH] fbdev: fsl-diu: remove redundant null check on cmap Wen Yang
2018-12-03 14:53 ` Timur Tabi [this message]
2018-12-20 17:58 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bda8bdc3-46cb-883d-1ddc-8fda0cf241be@kernel.org \
--to=timur@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wen.yang99@zte.com.cn \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).