From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA1B7C38A2D for ; Mon, 24 Oct 2022 20:17:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233099AbiJXURR (ORCPT ); Mon, 24 Oct 2022 16:17:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234120AbiJXUQb (ORCPT ); Mon, 24 Oct 2022 16:16:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06CECAA360 for ; Mon, 24 Oct 2022 11:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666636381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oBddTd2aL3cpMShQLUMXQ70zqgPBnwYQKQRFaU3QDlI=; b=Ada6OJa2NlkE2AdLLee0fzvLzo+lem0289PpI6sE7zUMBWTOw/Nmp5EWz/tsdDOLGGa231 TdYZspZvyqEx2+dpqSEk2N77mebrUyVk2xVo5ZMA2p11GLBMi0+81SxGLtYtdz8wbmZFWx u9F4k5YvsOmKMrHuTPyK7sMpGM3/JWU= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-316-9sYU2nO2PMOHDqKxcEOaTQ-1; Mon, 24 Oct 2022 08:00:19 -0400 X-MC-Unique: 9sYU2nO2PMOHDqKxcEOaTQ-1 Received: by mail-lj1-f200.google.com with SMTP id e9-20020a2ea549000000b0026fd9ba87acso3939407ljn.1 for ; Mon, 24 Oct 2022 05:00:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oBddTd2aL3cpMShQLUMXQ70zqgPBnwYQKQRFaU3QDlI=; b=Sb35imcp/FLa7rc8YsJQZVBeKhu6HMe42XyzR86jt+PMt7JxSdIYtDirsNQfAF5Zze E2F3U3+8kUqrG6ru5yLWEYPhBNYOaWLIW0cH0kHKRam43on2wGiSZkzQNpO5gA/A5uG0 29Qu35r/D6Byn9BcxrhROYffNM3hhKVWv6FVDMS8LcPNAOmWuzF7E7lKirMorRn4KueW eMrUqgSOQM0StV+nRaKp9GfemhUsr7W+AbMipbrOrIzcnpCG1JJOi7I/5iIQRu8h7fmT hZKZwXVGNxzKSwD1goLqUKJ81bVxM4r4XxnnHZgCWhUIQkRLhKvAuAEvzhb1yJ2sWLPj iIjA== X-Gm-Message-State: ACrzQf1W2C+VobbMHRwQD950YVMTUIslRewRHzXwtNrlfvD1fGKkO1Tx Dc/vojkgFwO7vEOg2cjEc0sUcbHrZZoIyG4Jw7TlkvHlf6C7JXexU2aKdN8CIFjJmeDA5Cszc8T dN6AQ1Ludz4HQao7NgqCvl4E= X-Received: by 2002:a05:651c:242:b0:26d:fb4b:9c8 with SMTP id x2-20020a05651c024200b0026dfb4b09c8mr12102665ljn.353.1666612816693; Mon, 24 Oct 2022 05:00:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4tdZDsl2pNG3Zoy+jU7SoBTHTkz51iCC/iggC9kztg6HWE+mkD8tnuNENa1Jj/GJlMZnu9qg== X-Received: by 2002:a17:907:6e24:b0:791:905f:7881 with SMTP id sd36-20020a1709076e2400b00791905f7881mr27267484ejc.120.1666612806299; Mon, 24 Oct 2022 05:00:06 -0700 (PDT) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id u20-20020a17090626d400b0078907275a44sm15446126ejc.42.2022.10.24.05.00.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 05:00:05 -0700 (PDT) Message-ID: Date: Mon, 24 Oct 2022 14:00:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 00/22] Fallback to native backlight Content-Language: en-US To: Akihiko Odaki , Jani Nikula Cc: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , "Rafael J. Wysocki" , Len Brown , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , "Lee, Chun-Yi" , Mark Gross , Corentin Chary , Cezary Jackiewicz , Matthew Garrett , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Jonathan Woithe , Ike Panhc , Daniel Dadap , Kenneth Chan , Mattia Dongili , Henrique de Moraes Holschuh , Azael Avalos , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Robert Moore , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, ibm-acpi-devel@lists.sourceforge.net, linux-fbdev@vger.kernel.org, devel@acpica.org References: <20221024113513.5205-1-akihiko.odaki@daynix.com> <87tu3te92n.fsf@intel.com> <18478739-625b-0c16-cd5a-e05c5372a74a@daynix.com> From: Hans de Goede In-Reply-To: <18478739-625b-0c16-cd5a-e05c5372a74a@daynix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi, On 10/24/22 13:56, Akihiko Odaki wrote: > On 2022/10/24 20:48, Jani Nikula wrote: >> On Mon, 24 Oct 2022, Akihiko Odaki wrote: >>> Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() >>> helper") and following commits made native backlight unavailable if >>> CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is >>> unavailable, which broke the backlight functionality on Lenovo ThinkPad >>> C13 Yoga Chromebook. Allow to fall back to native backlight in such >>> cases. >> >> Where's the bug report with relevant logs, kconfigs, etc? > > I haven't filed one. Should I? Please tell me where to report and what information you would need (to bugzilla.kernel.org with things mentioned in Documentation/admin-guide/reporting-issues.rst?) As mentioned in my other email this is a known issue, and your effort to fix this is appreciated very much, but I don't believe your solution to be the right one. See: https://lore.kernel.org/linux-acpi/42a5f2c9-a1dc-8fc0-7334-fe6c390ecfbb@redhat.com/ for more details and possible solutions. Please try implementing one of those solutions for your Chromebook. I unfortunately do not have hw to test this myself. Regards, Hans > > Regards, > Akihiko Odaki > >> >> BR, >> Jani. >> >>> >>> Signed-off-by: Akihiko Odaki >>> >>> Akihiko Odaki (22): >>>    drm/i915/opregion: Improve backlight request condition >>>    ACPI: video: Introduce acpi_video_get_backlight_types() >>>    LoongArch: Use acpi_video_get_backlight_types() >>>    platform/x86: acer-wmi: Use acpi_video_get_backlight_types() >>>    platform/x86: asus-laptop: Use acpi_video_get_backlight_types() >>>    platform/x86: asus-wmi: Use acpi_video_get_backlight_types() >>>    platform/x86: compal-laptop: Use acpi_video_get_backlight_types() >>>    platform/x86: eeepc-laptop: Use acpi_video_get_backlight_types() >>>    platform/x86: fujitsu-laptop: Use acpi_video_get_backlight_types() >>>    platform/x86: ideapad-laptop: Use acpi_video_get_backlight_types() >>>    platform/x86: msi-laptop: Use acpi_video_get_backlight_types() >>>    platform/x86: msi-wmi: Use acpi_video_get_backlight_types() >>>    platform/x86: nvidia-wmi-ec-backlight: Use >>>      acpi_video_get_backlight_types() >>>    platform/x86: panasonic-laptop: Use acpi_video_get_backlight_types() >>>    platform/x86: samsung-laptop: Use acpi_video_get_backlight_types() >>>    platform/x86: sony-laptop: Use acpi_video_get_backlight_types() >>>    platform/x86: thinkpad_acpi: Use acpi_video_get_backlight_types() >>>    platform/x86: toshiba_acpi: Use acpi_video_get_backlight_types() >>>    platform/x86: dell-laptop: Use acpi_video_get_backlight_types() >>>    platform/x86: intel_oaktrail: Use acpi_video_get_backlight_types() >>>    ACPI: video: Remove acpi_video_get_backlight_type() >>>    ACPI: video: Fallback to native backlight >>> >>>   Documentation/gpu/todo.rst                    |  8 +-- >>>   drivers/acpi/acpi_video.c                     |  2 +- >>>   drivers/acpi/video_detect.c                   | 54 ++++++++++--------- >>>   drivers/gpu/drm/i915/display/intel_opregion.c |  3 +- >>>   drivers/platform/loongarch/loongson-laptop.c  |  4 +- >>>   drivers/platform/x86/acer-wmi.c               |  2 +- >>>   drivers/platform/x86/asus-laptop.c            |  2 +- >>>   drivers/platform/x86/asus-wmi.c               |  4 +- >>>   drivers/platform/x86/compal-laptop.c          |  2 +- >>>   drivers/platform/x86/dell/dell-laptop.c       |  2 +- >>>   drivers/platform/x86/eeepc-laptop.c           |  2 +- >>>   drivers/platform/x86/fujitsu-laptop.c         |  4 +- >>>   drivers/platform/x86/ideapad-laptop.c         |  2 +- >>>   drivers/platform/x86/intel/oaktrail.c         |  2 +- >>>   drivers/platform/x86/msi-laptop.c             |  2 +- >>>   drivers/platform/x86/msi-wmi.c                |  2 +- >>>   .../platform/x86/nvidia-wmi-ec-backlight.c    |  2 +- >>>   drivers/platform/x86/panasonic-laptop.c       |  2 +- >>>   drivers/platform/x86/samsung-laptop.c         |  2 +- >>>   drivers/platform/x86/sony-laptop.c            |  2 +- >>>   drivers/platform/x86/thinkpad_acpi.c          |  4 +- >>>   drivers/platform/x86/toshiba_acpi.c           |  2 +- >>>   drivers/video/backlight/backlight.c           | 18 +++++++ >>>   include/acpi/video.h                          | 21 ++++---- >>>   include/linux/backlight.h                     |  1 + >>>   25 files changed, 85 insertions(+), 66 deletions(-) >> >