From: David Lechner <dlechner@baylibre.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Angelo Dureghello <adureghello@baylibre.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
linux-fbdev@vger.kernel.org, linux-iio@vger.kernel.org,
Guillaume Stols <gstols@baylibre.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
Alexandru Ardelean <aardelean@baylibre.com>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/9] dt-bindings: iio: dac: adi-axi-adc: add ad7606 variant
Date: Mon, 10 Feb 2025 11:46:31 -0600 [thread overview]
Message-ID: <c0f6e439-973c-43f2-bf6c-6a64551161cf@baylibre.com> (raw)
In-Reply-To: <173920794511.669517.12561205201983200892.robh@kernel.org>
On 2/10/25 11:19 AM, Rob Herring (Arm) wrote:
>
> On Mon, 10 Feb 2025 17:10:51 +0100, Angelo Dureghello wrote:
>> From: Guillaume Stols <gstols@baylibre.com>
>>
>> A new compatible is added to reflect the specialized version of the HDL.
>> We use the parallel interface to write the ADC's registers, and
>> accessing this interface requires to use ADI_AXI_REG_CONFIG_RD,
>> ADI_AXI_REG_CONFIG_WR and ADI_AXI_REG_CONFIG_CTRL in a custom fashion.
>>
>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>> Signed-off-by: Guillaume Stols <gstols@baylibre.com>
>> Co-developed-by: Angelo Dureghello <adureghello@baylibre.com>
>> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
>> ---
>> .../devicetree/bindings/iio/adc/adi,axi-adc.yaml | 70 +++++++++++++++++++++-
>> 1 file changed, 69 insertions(+), 1 deletion(-)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.example.dtb: adc@0: pwm-names: ['convst1'] is too short
> from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml#
Caused by missing dependency from v3 that Jonathan already picked up.
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id=02ccd7e5d81af4ae20852fc1ad67e7d943fa5778
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250210-wip-bl-ad7606_add_backend_sw_mode-v4-1-160df18b1da7@baylibre.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
next prev parent reply other threads:[~2025-02-10 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 16:10 [PATCH v4 0/9] add support for Software mode on AD7606's iio backend driver Angelo Dureghello
2025-02-10 16:10 ` [PATCH v4 1/9] dt-bindings: iio: dac: adi-axi-adc: add ad7606 variant Angelo Dureghello
2025-02-10 17:19 ` Rob Herring (Arm)
2025-02-10 17:46 ` David Lechner [this message]
2025-02-10 16:10 ` [PATCH v4 2/9] iio: adc: ad7606: move the software mode configuration Angelo Dureghello
2025-02-10 16:10 ` [PATCH v4 3/9] iio: adc: ad7606: move software functions into common file Angelo Dureghello
2025-02-10 16:10 ` [PATCH v4 4/9] iio: adc: adi-axi-adc: add struct axi_adc_info Angelo Dureghello
2025-02-10 16:10 ` [PATCH v4 5/9] iio: adc: adi-axi-adc: add platform children support Angelo Dureghello
2025-02-10 16:10 ` [PATCH v4 6/9] iio: adc: adi-axi-adc: add support for AD7606 register writing Angelo Dureghello
2025-02-10 16:10 ` [PATCH v4 7/9] iio: adc: ad7606: protect register access Angelo Dureghello
2025-02-10 16:10 ` [PATCH v4 8/9] iio: adc: ad7606: change channel macros parameters Angelo Dureghello
2025-02-10 16:10 ` [PATCH v4 9/9] iio: adc: ad7606: add support for writing registers when using backend Angelo Dureghello
2025-02-11 19:57 ` [PATCH v4 0/9] add support for Software mode on AD7606's iio backend driver Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0f6e439-973c-43f2-bf6c-6a64551161cf@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=aardelean@baylibre.com \
--cc=adureghello@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gstols@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).