From: Alan Stern <stern@rowland.harvard.edu>
To: Helge Deller <deller@gmx.de>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
syzbot <syzbot+0e22d63dcebb802b9bc8@syzkaller.appspotmail.com>,
bernie@plugable.com, linux-usb@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [fbdev?] [usb?] WARNING in dlfb_submit_urb/usb_submit_urb (2)
Date: Fri, 19 May 2023 11:42:52 -0400 [thread overview]
Message-ID: <c1cf7ff1-c204-4afc-aa9d-890e07d5ec72@rowland.harvard.edu> (raw)
In-Reply-To: <6e93305a-2d70-d411-3e36-c536449295dd@gmx.de>
On Fri, May 19, 2023 at 12:38:15PM +0200, Helge Deller wrote:
> Patch looks good and survived the test.
>
> Will you send a proper patch to the fbdev mailing list, so that I can
> include it?
Will do.
While you're working on this driver, here's a suggestion for another
improvement you can make. The temporary buffer allocations and calls to
usb_control_msg() in dlfb_get_edid() and dlfb_select_std_channel() can
be replaced with calls to usb_control_msg_recv() and
usb_control_msg_send() respectively.
Alan Stern
next prev parent reply other threads:[~2023-05-19 15:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 4:12 [syzbot] [fbdev?] [usb?] WARNING in dlfb_submit_urb/usb_submit_urb (2) syzbot
2023-05-18 7:34 ` Helge Deller
2023-05-18 7:40 ` syzbot
2023-05-18 13:54 ` Alan Stern
2023-05-18 14:16 ` Helge Deller
2023-05-18 14:56 ` Alan Stern
2023-05-18 19:06 ` Helge Deller
2023-05-18 20:35 ` Alan Stern
2023-05-18 21:08 ` syzbot
2023-05-19 10:38 ` Helge Deller
2023-05-19 15:42 ` Alan Stern [this message]
2023-05-19 18:40 ` Helge Deller
2023-05-19 19:32 ` [PATCH] video: udlfb: Fix endpoint check Alan Stern
2023-05-19 19:51 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1cf7ff1-c204-4afc-aa9d-890e07d5ec72@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=bernie@plugable.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=syzbot+0e22d63dcebb802b9bc8@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).