From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB48C77B7A for ; Fri, 19 May 2023 15:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232125AbjESPmz (ORCPT ); Fri, 19 May 2023 11:42:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbjESPmy (ORCPT ); Fri, 19 May 2023 11:42:54 -0400 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id C2C541A6 for ; Fri, 19 May 2023 08:42:52 -0700 (PDT) Received: (qmail 42012 invoked by uid 1000); 19 May 2023 11:42:52 -0400 Date: Fri, 19 May 2023 11:42:52 -0400 From: Alan Stern To: Helge Deller Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, syzbot , bernie@plugable.com, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [fbdev?] [usb?] WARNING in dlfb_submit_urb/usb_submit_urb (2) Message-ID: References: <0000000000004a222005fbf00461@google.com> <4cd17511-2b60-4c37-baf3-c477cf6d1761@rowland.harvard.edu> <2905a85f-4a3b-4a4f-b8fb-a4d037d6c591@rowland.harvard.edu> <6e93305a-2d70-d411-3e36-c536449295dd@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e93305a-2d70-d411-3e36-c536449295dd@gmx.de> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Fri, May 19, 2023 at 12:38:15PM +0200, Helge Deller wrote: > Patch looks good and survived the test. > > Will you send a proper patch to the fbdev mailing list, so that I can > include it? Will do. While you're working on this driver, here's a suggestion for another improvement you can make. The temporary buffer allocations and calls to usb_control_msg() in dlfb_get_edid() and dlfb_select_std_channel() can be replaced with calls to usb_control_msg_recv() and usb_control_msg_send() respectively. Alan Stern