From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F8BC433EF for ; Wed, 9 Mar 2022 11:25:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232006AbiCIL0g (ORCPT ); Wed, 9 Mar 2022 06:26:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231896AbiCIL0g (ORCPT ); Wed, 9 Mar 2022 06:26:36 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 383F31470ED for ; Wed, 9 Mar 2022 03:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646825137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wv7i2LTWDtTJ8HHIxm54uV0Jv8Qi32GxQRPuHkearAM=; b=f2lR9foSveSpnMTDvocmhDpv0KRjyB6uLirf80wTHMqdsnkofgwxu0rKnRdeOyj4BtAk51 kDwweRjtC524MFel7MPx0l2R2DfcVl2aB4o1ZnO8uLHgyJ2nrDCNCYprVYJ10it3mNxZ0S kIbJRAzOsDk45+/+/PIqeVz8SYQTDuk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-612-Cba3FtNSN2WCZboBdZnddA-1; Wed, 09 Mar 2022 06:25:36 -0500 X-MC-Unique: Cba3FtNSN2WCZboBdZnddA-1 Received: by mail-wr1-f72.google.com with SMTP id k20-20020adfc714000000b001e305cd1597so654282wrg.19 for ; Wed, 09 Mar 2022 03:25:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Wv7i2LTWDtTJ8HHIxm54uV0Jv8Qi32GxQRPuHkearAM=; b=2E7qAcZIWDKzoSIDesQmIy/k3qpwqVVtSIG1X22ceVf7IeQ4lan1p/DT0GrQxI9Q2H Hdyn/xjmeG3LmdZeej+GPM1AiDUL5zm8OYFJEM54Gg4b0LtkQ2vzsRD83+tPvSAZJx7L hoknNqrrbR6M91NQvZnDItZYRc2iPPTiTb/pdbBX2mkZ7ZTTRT7mKLFBs6mq/GSYRBxy qoCAbTYG6N6MxSPk3Tcrdtzu1vLrVnmyFGETSRSoDEN6SA+E4R9R/ExCidSg3Yp/IjLZ 376ZFCwOXouyz+8dUzoLnuSUZ5RJ8r48z/W/e0jo3iP7tewJsnH8kzh/DsVtueWxWEtM 0+9Q== X-Gm-Message-State: AOAM533Nf02LoYIrPmhStp0Bhwz3Dv9LyJOTV6aeZ3FkchpkaUFu9FK8 Dkg+pCOrjOQzHUL/cU5nDvzVcoh4U0Gtf1wqmUUfeW3CKeWmZeMCXVUgnqF+PccqAtPDz8iLbnM kZKSprvOQ4uRm/NOfTd+OQYE= X-Received: by 2002:adf:a302:0:b0:1ed:bf30:40e3 with SMTP id c2-20020adfa302000000b001edbf3040e3mr15810532wrb.270.1646825135091; Wed, 09 Mar 2022 03:25:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJyoTR3O7+oa02BuvxQ4coJ0ARpskt+/K+SxVoB3j1kHuRf5zct/QHm81A+/YYgNn/NIZBrRHQ== X-Received: by 2002:adf:a302:0:b0:1ed:bf30:40e3 with SMTP id c2-20020adfa302000000b001edbf3040e3mr15810518wrb.270.1646825134853; Wed, 09 Mar 2022 03:25:34 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id y12-20020adff14c000000b001f04d1959easm1414831wro.13.2022.03.09.03.25.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Mar 2022 03:25:34 -0800 (PST) Message-ID: Date: Wed, 9 Mar 2022 12:25:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 8/9] drm/gem-shmem: Implement fbdev dumb buffer and mmap helpers Content-Language: en-US To: Thomas Zimmermann , daniel@ffwll.ch, airlied@linux.ie, mripard@kernel.org, maarten.lankhorst@linux.intel.com, deller@gmx.de Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org References: <20220303205839.28484-1-tzimmermann@suse.de> <20220303205839.28484-9-tzimmermann@suse.de> <265aba53-ff78-e1ab-8596-e2226dff23f0@redhat.com> <22b9e772-8823-0af1-037a-621844e7c810@suse.de> From: Javier Martinez Canillas In-Reply-To: <22b9e772-8823-0af1-037a-621844e7c810@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 3/9/22 09:47, Thomas Zimmermann wrote: [snip] >>> >>> +static const struct drm_gem_object_funcs drm_gem_shmem_funcs_fbdev = { >>> + .free = drm_gem_shmem_object_free, >>> + .print_info = drm_gem_shmem_object_print_info, >>> + .pin = drm_gem_shmem_object_pin, >>> + .unpin = drm_gem_shmem_object_unpin, >>> + .get_sg_table = drm_gem_shmem_object_get_sg_table, >>> + .vmap = drm_gem_shmem_object_vmap, >>> + .vunmap = drm_gem_shmem_object_vunmap, >>> + .mmap = drm_gem_shmem_object_mmap_fbdev, >>> + .vm_ops = &drm_gem_shmem_vm_ops_fbdev, >> >> The drm_gem_shmem_funcs_fbdev is the same than drm_gem_shmem_funcs but >> .mmap and .vm_ops callbacks. Maybe adding a macro to declare these two >> struct drm_gem_object_funcs could make easier to maintain it long term ? > > I see you point, but I'm undecided about this. Such macros also add some > amount of obfuscation. I'm not sure if it's worth it for an internal > constant. And since the fbdev buffer is never exported, we could remove > some of the callbacks. AFAICT we never call pin, unpin or get_sg_table. > Yeah, that's true too. It was just a suggestion, I'm OK with patch as is. > Best regards > Thomas > >> -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat