[PATCH] fbdev: Use /* */ comment in initializer macro

[PATCH] fbdev: Use /* */ comment in initializer macro

[Thomas Zimmermann]

Use /* */ in initializer macro to avoid out-commenting the comma
at the end of the line.

Reported-by: Christian König <ckoenig.leichtzumerken@gmail.com>
Closes: https://lore.kernel.org/dri-devel/20230530150253.22758-1-tzimmermann@suse.de/T/#m356cda2679c17d7a01f30ce2b5282cd9046ea6d4
Fixes: f1061fa641b8 ("fbdev: Add initializer macros for struct fb_ops")
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 include/linux/fb.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/fb.h b/include/linux/fb.h
index ce6823e157e6b..ce7d588edc3e6 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -552,7 +552,7 @@ extern ssize_t fb_io_write(struct fb_info *info, const char __user *buf,
 	.fb_imageblit	= cfb_imageblit
 
 #define __FB_DEFAULT_IO_OPS_MMAP \
-	.fb_mmap	= NULL // default implementation
+	.fb_mmap	= NULL /* default implementation */
 
 #define FB_DEFAULT_IO_OPS \
 	__FB_DEFAULT_IO_OPS_RDWR, \
@@ -585,7 +585,7 @@ extern ssize_t fb_sys_write(struct fb_info *info, const char __user *buf,
 	.fb_imageblit	= sys_imageblit
 
 #define __FB_DEFAULT_SYS_OPS_MMAP \
-	.fb_mmap	= NULL // default implementation
+	.fb_mmap	= NULL /* default implementation */
 
 #define FB_DEFAULT_SYS_OPS \
 	__FB_DEFAULT_SYS_OPS_RDWR, \
-- 
2.41.0

Re: [PATCH] fbdev: Use /* */ comment in initializer macro

[Christian König]

Am 14.06.23 um 15:12 schrieb Thomas Zimmermann:
> Use /* */ in initializer macro to avoid out-commenting the comma
> at the end of the line.
>
> Reported-by: Christian König <ckoenig.leichtzumerken@gmail.com>
> Closes: https://lore.kernel.org/dri-devel/20230530150253.22758-1-tzimmermann@suse.de/T/#m356cda2679c17d7a01f30ce2b5282cd9046ea6d4
> Fixes: f1061fa641b8 ("fbdev: Add initializer macros for struct fb_ops")
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   include/linux/fb.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index ce6823e157e6b..ce7d588edc3e6 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -552,7 +552,7 @@ extern ssize_t fb_io_write(struct fb_info *info, const char __user *buf,
>   	.fb_imageblit	= cfb_imageblit
>   
>   #define __FB_DEFAULT_IO_OPS_MMAP \
> -	.fb_mmap	= NULL // default implementation
> +	.fb_mmap	= NULL /* default implementation */
>   
>   #define FB_DEFAULT_IO_OPS \
>   	__FB_DEFAULT_IO_OPS_RDWR, \
> @@ -585,7 +585,7 @@ extern ssize_t fb_sys_write(struct fb_info *info, const char __user *buf,
>   	.fb_imageblit	= sys_imageblit
>   
>   #define __FB_DEFAULT_SYS_OPS_MMAP \
> -	.fb_mmap	= NULL // default implementation
> +	.fb_mmap	= NULL /* default implementation */
>   
>   #define FB_DEFAULT_SYS_OPS \
>   	__FB_DEFAULT_SYS_OPS_RDWR, \