From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA88C433F5 for ; Mon, 31 Jan 2022 23:21:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238137AbiAaXVr (ORCPT ); Mon, 31 Jan 2022 18:21:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:37955 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238117AbiAaXVr (ORCPT ); Mon, 31 Jan 2022 18:21:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643671306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PrT+G3tPg9tF+5XuIAQ32IRnOTQfqMCqOg72JDwqGHg=; b=az5rQSicjcNnkTP+5PCfY0d/hlIeIXcmwsiHxr7eKNMPJLB4Bd/QAE4NpiczzZvNwAYdSA CPp11YGb0aiMdAQOD/no0or3IZ14ouGX8cFTXB6rrSKrnA8WBks3dQM0yYMRMGnpI8tx2U gLzqD1QJv37GPvpOAmjbE37eWDze8O0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-163-NWq-4y2ePQqKMMvkpE_6qQ-1; Mon, 31 Jan 2022 18:21:44 -0500 X-MC-Unique: NWq-4y2ePQqKMMvkpE_6qQ-1 Received: by mail-wm1-f70.google.com with SMTP id s1-20020a1ca901000000b0034ece94dd8cso419500wme.5 for ; Mon, 31 Jan 2022 15:21:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PrT+G3tPg9tF+5XuIAQ32IRnOTQfqMCqOg72JDwqGHg=; b=2WtRNC8T7Ga4qcyBpATOA1PW4AUP4t4ycNVZe7jfVxo5iiuQP1zabdEbiVtsUH7M8E mU8Puim6rbjdwh8QSIBt0Z/XamSR+JxjWLsrEhxb5w2vep+WTYsMkwk90g9mQ1SywnZy XfSokvnS3Gu0YfHoR5FQ/JuCw+xV7akgqW0Wr8DM/6ygNsqlMlLtYpUBarQW5uL4neTP HGrtMH/PVRQO57VRJ9zeOO4PrSGJo/PcUBWmzPbfnGpkjksMsLYu205weFIMevramg0E 9NxlGcOGQzQpdouKsWQ14x4re2H9JLLFF6VEbDPOfrc7gPh//4PXuOxNKbm/vJS47+P9 Mepw== X-Gm-Message-State: AOAM532B5YXkLJannSozlbMGeanPnW48KGYqyJ5hXkfT3FKNchwvT0+F UhH7MWSKnymG6xA86I+0QeygND9OICUS6gRIggO0/NwoCbt7LkA32uW7J/6qyRxXa0T79UyS4dU KtBzxC6na2SO2iZJwoFDmWuc= X-Received: by 2002:a7b:c44d:: with SMTP id l13mr28332776wmi.46.1643671303289; Mon, 31 Jan 2022 15:21:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJz+5Kta65CM2LqtBZ8N7f7NRu724ZDFebRcaJ9B9wuQH3sMcUBfk67n6fa4xazee4fo9ruHBg== X-Received: by 2002:a7b:c44d:: with SMTP id l13mr28332767wmi.46.1643671303032; Mon, 31 Jan 2022 15:21:43 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id p3sm515814wmq.40.2022.01.31.15.21.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 15:21:42 -0800 (PST) Message-ID: Date: Tue, 1 Feb 2022 00:21:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Content-Language: en-US To: Simon Ser Cc: linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann , David Airlie , Daniel Vetter , Mark Brown , dri-devel@lists.freedesktop.org, Liam Girdwood , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Geert Uytterhoeven , Maxime Ripard , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Thierry Reding , Andy Shevchenko , Lee Jones References: <20220131201225.2324984-1-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hello Simon, Thanks for your feedback. On 1/31/22 21:39, Simon Ser wrote: > On Monday, January 31st, 2022 at 21:36, Simon Ser wrote: > >> This driver only advertises XRGB8888 in ssd1307_formats. It would be nice to >> expose R8 as well so that user-space can directly produce suitable buffers. >> It would also be nice to have some kind of preferred format, so that user-space >> knows R8 is preferred over XRGB8888. > > Hm, since the format used by the hw is actually R1, adding that to drm_fourcc.h > would be even better. > Yes, agreed that would be nice. We discussed this already with Thomas and my suggestion was to land the driver as is, advertising XRGB8888. Which is also what the other driver using monochrome does (drivers/gpu/drm/tiny/repaper.c): https://www.spinics.net/lists/dri-devel/msg331328.html As a follow-up we can wire up al the needed bits to have a DRM/KMS driver that could expose a R1 format. > Let me know if you want me to type up any of the user-space bits. > Thanks! I also could help to add the needed support in the user-space stack. Best reagards, -- Javier Martinez Canillas Linux Engineering Red Hat