* [PATCH v1 1/1] fbdev: omapfb: Replace custom memparse() implementation
@ 2023-10-18 3:47 Andy Shevchenko
2023-10-18 6:13 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2023-10-18 3:47 UTC (permalink / raw)
To: linux-fbdev, linux-omap, dri-devel, linux-kernel
Cc: Helge Deller, Andy Shevchenko
Our library has memparse() for parsing numbers with respective suffixes
suitable for memory sizes. Use it instead of custom implementation.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/video/fbdev/omap/omapfb_main.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index 631076bf71f9..694cf6318782 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1856,20 +1856,13 @@ static int __init omapfb_setup(char *options)
if (!strncmp(this_opt, "accel", 5))
def_accel = 1;
else if (!strncmp(this_opt, "vram:", 5)) {
+ unsigned long long vram;
char *suffix;
- unsigned long vram;
- vram = (simple_strtoul(this_opt + 5, &suffix, 0));
+
+ vram = memparse(this_opt + 5, &suffix);
switch (suffix[0]) {
case '\0':
break;
- case 'm':
- case 'M':
- vram *= 1024;
- fallthrough;
- case 'k':
- case 'K':
- vram *= 1024;
- break;
default:
pr_debug("omapfb: invalid vram suffix %c\n",
suffix[0]);
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] fbdev: omapfb: Replace custom memparse() implementation
2023-10-18 3:47 [PATCH v1 1/1] fbdev: omapfb: Replace custom memparse() implementation Andy Shevchenko
@ 2023-10-18 6:13 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2023-10-18 6:13 UTC (permalink / raw)
To: Andy Shevchenko, linux-fbdev, linux-omap, dri-devel, linux-kernel
On 10/18/23 05:47, Andy Shevchenko wrote:
> Our library has memparse() for parsing numbers with respective suffixes
> suitable for memory sizes. Use it instead of custom implementation.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/video/fbdev/omap/omapfb_main.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
both patches applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-18 6:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-18 3:47 [PATCH v1 1/1] fbdev: omapfb: Replace custom memparse() implementation Andy Shevchenko
2023-10-18 6:13 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).