* [PATCH] fbdev/pvr2fb: Fix leftover reference to ONCHIP_NR_DMA_CHANNELS
@ 2025-10-25 22:38 Florian Fuchs
2025-10-25 23:14 ` John Paul Adrian Glaubitz
2025-10-28 21:16 ` Helge Deller
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fuchs @ 2025-10-25 22:38 UTC (permalink / raw)
To: Helge Deller, linux-fbdev; +Cc: linux-kernel, linux-sh, dri-devel, fuchsfl
Commit e24cca19babe ("sh: Kill off MAX_DMA_ADDRESS leftovers.") removed
the define ONCHIP_NR_DMA_CHANNELS. So that the leftover reference needs
to be replaced by CONFIG_NR_ONCHIP_DMA_CHANNELS to compile successfully
with CONFIG_PVR2_DMA enabled.
Signed-off-by: Florian Fuchs <fuchsfl@gmail.com>
---
Note: The fix has been compiled, and tested on real Dreamcast hardware,
with CONFIG_PVR2_DMA=y.
drivers/video/fbdev/pvr2fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
index cbdb1caf61bd..0b8d23c12b77 100644
--- a/drivers/video/fbdev/pvr2fb.c
+++ b/drivers/video/fbdev/pvr2fb.c
@@ -192,7 +192,7 @@ static unsigned long pvr2fb_map;
#ifdef CONFIG_PVR2_DMA
static unsigned int shdma = PVR2_CASCADE_CHAN;
-static unsigned int pvr2dma = ONCHIP_NR_DMA_CHANNELS;
+static unsigned int pvr2dma = CONFIG_NR_ONCHIP_DMA_CHANNELS;
#endif
static struct fb_videomode pvr2_modedb[] = {
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fbdev/pvr2fb: Fix leftover reference to ONCHIP_NR_DMA_CHANNELS
2025-10-25 22:38 [PATCH] fbdev/pvr2fb: Fix leftover reference to ONCHIP_NR_DMA_CHANNELS Florian Fuchs
@ 2025-10-25 23:14 ` John Paul Adrian Glaubitz
2025-10-28 21:16 ` Helge Deller
1 sibling, 0 replies; 3+ messages in thread
From: John Paul Adrian Glaubitz @ 2025-10-25 23:14 UTC (permalink / raw)
To: Florian Fuchs, Helge Deller, linux-fbdev
Cc: linux-kernel, linux-sh, dri-devel
Hi Florian,
On Sun, 2025-10-26 at 00:38 +0200, Florian Fuchs wrote:
> Commit e24cca19babe ("sh: Kill off MAX_DMA_ADDRESS leftovers.") removed
> the define ONCHIP_NR_DMA_CHANNELS. So that the leftover reference needs
> to be replaced by CONFIG_NR_ONCHIP_DMA_CHANNELS to compile successfully
> with CONFIG_PVR2_DMA enabled.
>
> Signed-off-by: Florian Fuchs <fuchsfl@gmail.com>
> ---
> Note: The fix has been compiled, and tested on real Dreamcast hardware,
> with CONFIG_PVR2_DMA=y.
>
> drivers/video/fbdev/pvr2fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
> index cbdb1caf61bd..0b8d23c12b77 100644
> --- a/drivers/video/fbdev/pvr2fb.c
> +++ b/drivers/video/fbdev/pvr2fb.c
> @@ -192,7 +192,7 @@ static unsigned long pvr2fb_map;
>
> #ifdef CONFIG_PVR2_DMA
> static unsigned int shdma = PVR2_CASCADE_CHAN;
> -static unsigned int pvr2dma = ONCHIP_NR_DMA_CHANNELS;
> +static unsigned int pvr2dma = CONFIG_NR_ONCHIP_DMA_CHANNELS;
> #endif
>
> static struct fb_videomode pvr2_modedb[] = {
>
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
Good catch, thanks for fixing this!
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fbdev/pvr2fb: Fix leftover reference to ONCHIP_NR_DMA_CHANNELS
2025-10-25 22:38 [PATCH] fbdev/pvr2fb: Fix leftover reference to ONCHIP_NR_DMA_CHANNELS Florian Fuchs
2025-10-25 23:14 ` John Paul Adrian Glaubitz
@ 2025-10-28 21:16 ` Helge Deller
1 sibling, 0 replies; 3+ messages in thread
From: Helge Deller @ 2025-10-28 21:16 UTC (permalink / raw)
To: Florian Fuchs, linux-fbdev; +Cc: linux-kernel, linux-sh, dri-devel
On 10/26/25 00:38, Florian Fuchs wrote:
> Commit e24cca19babe ("sh: Kill off MAX_DMA_ADDRESS leftovers.") removed
> the define ONCHIP_NR_DMA_CHANNELS. So that the leftover reference needs
> to be replaced by CONFIG_NR_ONCHIP_DMA_CHANNELS to compile successfully
> with CONFIG_PVR2_DMA enabled.
>
> Signed-off-by: Florian Fuchs <fuchsfl@gmail.com>
> ---
> Note: The fix has been compiled, and tested on real Dreamcast hardware,
> with CONFIG_PVR2_DMA=y.
>
> drivers/video/fbdev/pvr2fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-28 21:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-25 22:38 [PATCH] fbdev/pvr2fb: Fix leftover reference to ONCHIP_NR_DMA_CHANNELS Florian Fuchs
2025-10-25 23:14 ` John Paul Adrian Glaubitz
2025-10-28 21:16 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).