From: Andy Lutomirski <luto@amacapital.net>
To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org
Cc: Andy Lutomirski <luto@amacapital.net>
Subject: [PATCH 0/7] Clean up write-combining MTRR addition
Date: Fri, 03 May 2013 23:00:28 +0000 [thread overview]
Message-ID: <cover.1367621038.git.luto@amacapital.net> (raw)
A fair number of drivers (mostly graphics) add write-combining MTRRs.
Most ignore errors and most add the MTRR even on PAT systems which don't
need to use MTRRs.
This series adds new functions mtrr_{add,del}_wc_if_needed and
drm_mtrr_{add,del}_wc that report errors and do nothing if PAT is
enabled.
I've only tested the radeon driver, since I don't have test hardware
easily available for the other drivers.
Benefits include:
- Simpler code
- No more complaints about MTRR conflict warnings on PAT systems
- Eventual unexporting of the MTRR API?
This series eliminates about half of the mtrr_add calls in drivers/.
The series is also at:
https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/log/?h=mtrr_cleanup
Andy Lutomirski (7):
x86: Add mtrr_{add,del}_wc_if_needed
drm (ast,cirrus,mgag200,nouveau,savage,vmwgfx): Rework
drm_mtrr_{add,del}
drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs
drm: Use drm_mtrr_add_wc for the AGP aperture
i915: Use drm_mtrr_{add,del}_wc
radeon: Switch to drm_mtrr_add_wc and add a missing drm_mtrr_del_wc
uvesafb: Clean up MTRR code
Documentation/fb/uvesafb.txt | 16 +++-----
arch/x86/include/asm/mtrr.h | 21 ++++++++++
arch/x86/kernel/cpu/mtrr/main.c | 53 +++++++++++++++++++++++++
drivers/gpu/drm/ast/ast_ttm.c | 14 ++-----
drivers/gpu/drm/cirrus/cirrus_ttm.c | 15 ++------
drivers/gpu/drm/drm_bufs.c | 11 ++----
drivers/gpu/drm/drm_pci.c | 8 ++--
drivers/gpu/drm/drm_stub.c | 10 +----
drivers/gpu/drm/drm_vm.c | 13 ++++---
drivers/gpu/drm/i915/i915_dma.c | 43 +++------------------
drivers/gpu/drm/mgag200/mgag200_ttm.c | 14 ++-----
drivers/gpu/drm/nouveau/nouveau_ttm.c | 13 ++-----
drivers/gpu/drm/radeon/radeon_object.c | 5 ++-
drivers/gpu/drm/savage/savage_bci.c | 42 ++++++++------------
drivers/gpu/drm/savage/savage_drv.h | 5 +--
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 10 ++---
drivers/video/uvesafb.c | 70 +++++++++-------------------------
include/drm/drmP.h | 23 +++++------
include/video/uvesafb.h | 1 +
19 files changed, 169 insertions(+), 218 deletions(-)
--
1.8.1.4
next reply other threads:[~2013-05-03 23:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 23:00 Andy Lutomirski [this message]
2013-05-03 23:00 ` [PATCH 1/7] x86: Add mtrr_{add,del}_wc_if_needed Andy Lutomirski
2013-05-03 23:00 ` [PATCH 2/7] drm (ast,cirrus,mgag200,nouveau,savage,vmwgfx): Rework drm_mtrr_{add,del} Andy Lutomirski
2013-05-04 17:45 ` [PATCH 2/7] drm (ast, cirrus, mgag200, nouveau, savage, vmwgfx): Rework drm_mtrr_{add, del} Daniel Vetter
2013-05-04 17:48 ` Andy Lutomirski
2013-05-03 23:00 ` [PATCH 3/7] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs Andy Lutomirski
2013-05-06 21:22 ` Andy Lutomirski
2013-05-06 23:04 ` Jerome Glisse
2013-05-06 23:39 ` Andy Lutomirski
2013-05-07 3:09 ` Dave Airlie
2013-05-07 14:08 ` Alex Deucher
2013-05-07 16:45 ` Andy Lutomirski
2013-05-03 23:00 ` [PATCH 4/7] drm: Use drm_mtrr_add_wc for the AGP aperture Andy Lutomirski
2013-05-03 23:00 ` [PATCH 5/7] i915: Use drm_mtrr_{add,del}_wc Andy Lutomirski
2013-05-03 23:00 ` [PATCH 6/7] radeon: Switch to drm_mtrr_add_wc and add a missing drm_mtrr_del_wc Andy Lutomirski
2013-05-03 23:00 ` [PATCH 7/7] uvesafb: Clean up MTRR code Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1367621038.git.luto@amacapital.net \
--to=luto@amacapital.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).