* [PATCH 00/18] treewide: Move storage class before return type
@ 2017-07-05 20:02 Joe Perches
2017-07-05 20:02 ` [PATCH 15/18] video: fbdev: intelfb: Move inline " Joe Perches
2017-07-05 20:02 ` [PATCH 16/18] video: fbdev: omap: " Joe Perches
0 siblings, 2 replies; 3+ messages in thread
From: Joe Perches @ 2017-07-05 20:02 UTC (permalink / raw)
To: Andrew Morton, kvm, linux-arm-kernel, kvmarm, linux-m68k,
linux-efi, linux-s390, linux-serial, linux-ia64, linux-usb,
linux-fbdev, linux-omap, alsa-devel
Cc: linux-mips, linux-kernel, linux-cris-kernel, linux-sh
Move the inline/asmlinkage keywords before the return types
Add a checkpatch test for this too.
Joe Perches (18):
checkpatch: improve the STORAGE_CLASS test
ARM: KVM: Move asmlinkage before type
ARM: HP Jornada 7XX: Move inline before return type
CRIS: gpio: Move inline before return type
FRV: tlbflush: Move asmlinkage before return type
ia64: Move inline before return type
ia64: sn: pci: Move inline before type
m68k: coldfire: Move inline before return type
MIPS: SMP: Move asmlinkage before return type
sh: Move inline before return type
x86/efi: Move asmlinkage before return type
drivers: s390: Move static and inline before return type
drivers: tty: serial: Move inline before return type
USB: serial: safe_serial: Move __inline__ before return type
video: fbdev: intelfb: Move inline before return type
video: fbdev: omap: Move inline before return type
ARM: samsung: usb-ohci: Move inline before return type
ALSA: opl4: Move inline before return type
arch/arm/include/asm/kvm_hyp.h | 8 ++++----
arch/arm/mach-sa1100/jornada720_ssp.c | 2 +-
arch/cris/arch-v10/drivers/gpio.c | 4 ++--
arch/frv/include/asm/tlbflush.h | 8 ++++----
arch/ia64/kernel/mca.c | 2 +-
arch/ia64/sn/pci/pcibr/pcibr_ate.c | 2 +-
arch/ia64/sn/pci/tioce_provider.c | 4 ++--
arch/m68k/coldfire/intc-simr.c | 4 ++--
arch/mips/include/asm/smp.h | 2 +-
arch/sh/mm/cache-sh5.c | 2 +-
arch/x86/include/asm/efi.h | 4 ++--
drivers/s390/net/ctcm_main.c | 2 +-
drivers/s390/net/qeth_l3_main.c | 2 +-
drivers/tty/serial/ioc3_serial.c | 4 ++--
drivers/tty/serial/ioc4_serial.c | 4 ++--
drivers/usb/serial/safe_serial.c | 2 +-
drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +-
drivers/video/fbdev/omap/lcdc.c | 6 +++---
include/linux/platform_data/usb-ohci-s3c2410.h | 2 +-
scripts/checkpatch.pl | 12 ++++++++++--
sound/drivers/opl4/opl4_lib.c | 2 +-
21 files changed, 44 insertions(+), 36 deletions(-)
--
2.10.0.rc2.1.g053435c
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 15/18] video: fbdev: intelfb: Move inline before return type
2017-07-05 20:02 [PATCH 00/18] treewide: Move storage class before return type Joe Perches
@ 2017-07-05 20:02 ` Joe Perches
2017-07-05 20:02 ` [PATCH 16/18] video: fbdev: omap: " Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2017-07-05 20:02 UTC (permalink / raw)
To: Andrew Morton, Maik Broemme
Cc: Bartlomiej Zolnierkiewicz, linux-fbdev, linux-kernel
Make the code like the rest of the kernel.
But there is an oddity here because the inline should probably be removed.
It's an extern function in intelfb.h and it is used in intelfbdrv.c and
intelfbhw.c.
The inline is kept here as I suppose it's possible for some compiler to
make the uses inline in intelfbdrv and and also create an external function
for intelfbhw.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
index 6b444400a86c..ffc391208b27 100644
--- a/drivers/video/fbdev/intelfb/intelfbdrv.c
+++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
@@ -907,7 +907,7 @@ static void intelfb_pci_unregister(struct pci_dev *pdev)
* helper functions *
***************************************************************/
-int __inline__ intelfb_var_to_depth(const struct fb_var_screeninfo *var)
+__inline__ int intelfb_var_to_depth(const struct fb_var_screeninfo *var)
{
DBG_MSG("intelfb_var_to_depth: bpp: %d, green.length is %d\n",
var->bits_per_pixel, var->green.length);
--
2.10.0.rc2.1.g053435c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 16/18] video: fbdev: omap: Move inline before return type
2017-07-05 20:02 [PATCH 00/18] treewide: Move storage class before return type Joe Perches
2017-07-05 20:02 ` [PATCH 15/18] video: fbdev: intelfb: Move inline " Joe Perches
@ 2017-07-05 20:02 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2017-07-05 20:02 UTC (permalink / raw)
To: Andrew Morton, Tomi Valkeinen
Cc: Bartlomiej Zolnierkiewicz, linux-fbdev, linux-omap, linux-kernel
Make the code like the rest of the kernel.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/video/fbdev/omap/lcdc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/omap/lcdc.c b/drivers/video/fbdev/omap/lcdc.c
index e3d9b9ea5498..938cba0d24ae 100644
--- a/drivers/video/fbdev/omap/lcdc.c
+++ b/drivers/video/fbdev/omap/lcdc.c
@@ -79,12 +79,12 @@ static struct omap_lcd_controller {
unsigned long vram_size;
} lcdc;
-static void inline enable_irqs(int mask)
+static inline void enable_irqs(int mask)
{
lcdc.irq_mask |= mask;
}
-static void inline disable_irqs(int mask)
+static inline void disable_irqs(int mask)
{
lcdc.irq_mask &= ~mask;
}
@@ -466,7 +466,7 @@ static void calc_ck_div(int is_tft, int pck, int *pck_div)
}
}
-static void inline setup_regs(void)
+static inline void setup_regs(void)
{
u32 l;
struct lcd_panel *panel = lcdc.fbdev->panel;
--
2.10.0.rc2.1.g053435c
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-05 20:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-05 20:02 [PATCH 00/18] treewide: Move storage class before return type Joe Perches
2017-07-05 20:02 ` [PATCH 15/18] video: fbdev: intelfb: Move inline " Joe Perches
2017-07-05 20:02 ` [PATCH 16/18] video: fbdev: omap: " Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).