From: Nam Cao <namcao@linutronix.de>
To: Jaya Kumar <jayalk@intworks.biz>, Daniel Vetter <daniel@ffwll.ch>,
Helge Deller <deller@gmx.de>, Antonino Daplas <adaplas@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Mundt <lethal@linux-sh.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: bigeasy@linutronix.de, Nam Cao <namcao@linutronix.de>
Subject: [PATCH 0/2] fix LCD diplays sporadically not work
Date: Mon, 18 Dec 2023 10:57:29 +0100 [thread overview]
Message-ID: <cover.1702890493.git.namcao@linutronix.de> (raw)
Hi,
While working with a framebuffer displays, I noticed that the displays
sporadically do not show the image as I expect.
After investigation: this is because my devices use deferred IO, and by
closing the framebuffers, all pending deferred IO get cancelled. This
causes the image I sent to the devices to just vanish. Using fsync() does
not always help, because the driver's implementation of fsync() does not
guarantee that all pending work is flushed on return.
This series solves the problem by flush the workqueue in .release(). Also
flush the workqueue in .fsync(), as it is supposed to do.
Nam Cao (2):
fb: flush deferred work in fb_deferred_io_fsync()
fb: flush deferred IO before closing
drivers/video/fbdev/core/fb_defio.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
--
2.39.2
next reply other threads:[~2023-12-18 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 9:57 Nam Cao [this message]
2023-12-18 9:57 ` [PATCH 1/2] fb: flush deferred work in fb_deferred_io_fsync() Nam Cao
2023-12-19 7:43 ` Helge Deller
2023-12-18 9:57 ` [PATCH 2/2] fb: flush deferred IO before closing Nam Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1702890493.git.namcao@linutronix.de \
--to=namcao@linutronix.de \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jayalk@intworks.biz \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).