From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A7BA3CFF60 for ; Wed, 8 Apr 2026 13:46:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775655971; cv=none; b=Hl2bjJvm/xSAvUCTj7LgBw77wvE3XcStCawYFi8oqKnWCHCEfC46WUhZNbdrH/r1wScGpoKLPbKhXJzk0hH3OZ0ezuQvJGic78ZHi1qfQ11eNPgt8DTzMyZ9+j2ING/gUiufGFbz8Va4MSXn87tQtzFE4A1QRddhoMqLtt32iOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775655971; c=relaxed/simple; bh=YHXEtl2oP+cV8K2Sx7ZVkKvy3aol+D7ON1x6VTixXeE=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=ISQKOdeX3jEfzXuXbiyLHIBBRhwAUu3d37Er8MUd4NoBhBoFtW5DkxLifIKkKtf2PhSr6/aa1G0IvSQb+imDbWOGRhOMqKY45T9/43yfQmHs4t4jxGmBfseAWnJsQcQQa0PTn4tMG33J+/t36qPw74FAwKwavdSwsNNrWiLX/JA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dBkMBPLS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dBkMBPLS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACCD3C4AF0B; Wed, 8 Apr 2026 13:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775655971; bh=YHXEtl2oP+cV8K2Sx7ZVkKvy3aol+D7ON1x6VTixXeE=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=dBkMBPLSwNn5Oz4u9q3bGUCkZ+SspH2Ijjj38IvisJBYF9sksjdgH+mtTTO+AR+zU o7GqqJOqTVvf+63hMJIqTDO6ZtjBBZ1KWW/WEM1jq/pC8roF6HkoAjxBzye3QvgmX6 4AU1uBSTwtvFJ8ioX3WFVljd5WPvCr6heCscIHLQwkujU6jTc4f3oFecfcfmyVlc3G il4BSPfgpM0ptAu9TXPBLy4NxtakufGYa9keUdDXNo/h6qwtRIAN2hRUTCZaTqSTbl cJHZ7FKTJtflrQmamStLcBH/HK2RYMbakCEqi1EyriG8h+O1UHlasySLyATodXywVQ 1V+omoKGXWyew== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id 9F0F3F40088; Wed, 8 Apr 2026 09:46:09 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-01.internal (MEProxy); Wed, 08 Apr 2026 09:46:09 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddvfeejfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdetrhguuceu ihgvshhhvghuvhgvlhdfuceorghruggssehkvghrnhgvlhdrohhrgheqnecuggftrfgrth htvghrnhepvdeuheeitdevtdelkeduudetgffftdelteefteevjeevjeeiheefhfejieej fedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrugdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudeijedthedttdejledq feefvdduieegudehqdgrrhgusgeppehkvghrnhgvlhdrohhrghesfihorhhkohhfrghrug drtghomhdpnhgspghrtghpthhtohepvdegpdhmohguvgepshhmthhpohhuthdprhgtphht thhopegrrhhnugesrghrnhgusgdruggvpdhrtghpthhtohepshhimhhonhgrsehffhiflh hlrdgthhdprhgtphhtthhopegrihhrlhhivggusehgmhgrihhlrdgtohhmpdhrtghpthht ohepuggvlhhlvghrsehgmhigrdguvgdprhgtphhtthhopehlkhhpsehinhhtvghlrdgtoh hmpdhrtghpthhtoheptghhvghnhhhurggtrghisehkvghrnhgvlhdrohhrghdprhgtphht thhopehmrhhiphgrrhgusehkvghrnhgvlhdrohhrghdprhgtphhtthhopeifvghirdhlih husehkvghrnhgvlhdrohhrghdprhgtphhtthhopehilhhirghsrdgrphgrlhhoughimhgr sheslhhinhgrrhhordhorhhg X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 67B23700069; Wed, 8 Apr 2026 09:46:09 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AXf1VD975dY- Date: Wed, 08 Apr 2026 15:45:49 +0200 From: "Ard Biesheuvel" To: "Thomas Zimmermann" , "Javier Martinez Canillas" , "Arnd Bergmann" , "Ilias Apalodimas" , "Huacai Chen" , "WANG Xuerui" , maarten.lankhorst@linux.intel.com, mripard@kernel.org, "David Airlie" , "Simona Vetter" , kys@microsoft.com, haiyangz@microsoft.com, "Wei Liu" , decui@microsoft.com, "Long Li" , "Helge Deller" Cc: linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-hyperv@vger.kernel.org, linux-fbdev@vger.kernel.org, "kernel test robot" Message-Id: In-Reply-To: <20260402092305.208728-3-tzimmermann@suse.de> References: <20260402092305.208728-1-tzimmermann@suse.de> <20260402092305.208728-3-tzimmermann@suse.de> Subject: Re: [PATCH 2/8] firmware: efi: Never declare sysfb_primary_display on x86 Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi Thomas, On Thu, 2 Apr 2026, at 11:09, Thomas Zimmermann wrote: > The x86 architecture comes with its own instance of the global > state variable sysfb_primary_display. Never declare it in the EFI > subsystem. Fix the test for CONFIG_FIRMWARE_EDID accordingly. > > Signed-off-by: Thomas Zimmermann > Fixes: e65ca1646311 ("efi: export sysfb_primary_display for EDID") > Cc: kernel test robot > Cc: Arnd Bergmann > Cc: Thomas Zimmermann > Cc: Ard Biesheuvel > Cc: Ilias Apalodimas > Cc: linux-efi@vger.kernel.org > --- > drivers/firmware/efi/efi-init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Should this be sent out as a fix?