* [PATCH] video/fbdev/vt8500lcdfb: Delete an error message for a failed memory allocation in vt8500lcd
@ 2017-11-24 19:53 ` SF Markus Elfring
2017-12-29 17:53 ` [PATCH] video/fbdev/vt8500lcdfb: Delete an error message for a failed memory allocation in vt850 Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-11-24 19:53 UTC (permalink / raw)
To: dri-devel, linux-arm-kernel, linux-fbdev,
Bartlomiej Zolnierkiewicz, Tony Prisk
Cc: kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 24 Nov 2017 20:42:08 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/video/fbdev/vt8500lcdfb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c
index 1a1176bf0906..5c5cd2923041 100644
--- a/drivers/video/fbdev/vt8500lcdfb.c
+++ b/drivers/video/fbdev/vt8500lcdfb.c
@@ -289,10 +289,8 @@ static int vt8500lcd_probe(struct platform_device *pdev)
fbi = devm_kzalloc(&pdev->dev, sizeof(struct vt8500lcd_info)
+ sizeof(u32) * 16, GFP_KERNEL);
- if (!fbi) {
- dev_err(&pdev->dev, "Failed to initialize framebuffer device\n");
+ if (!fbi)
return -ENOMEM;
- }
strcpy(fbi->fb.fix.id, "VT8500 LCD");
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video/fbdev/vt8500lcdfb: Delete an error message for a failed memory allocation in vt850
2017-11-24 19:53 ` [PATCH] video/fbdev/vt8500lcdfb: Delete an error message for a failed memory allocation in vt8500lcd SF Markus Elfring
@ 2017-12-29 17:53 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-12-29 17:53 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-fbdev, kernel-janitors, LKML, dri-devel, Tony Prisk,
linux-arm-kernel
On Friday, November 24, 2017 08:53:02 PM SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 24 Nov 2017 20:42:08 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/video/fbdev/vt8500lcdfb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c
> index 1a1176bf0906..5c5cd2923041 100644
> --- a/drivers/video/fbdev/vt8500lcdfb.c
> +++ b/drivers/video/fbdev/vt8500lcdfb.c
> @@ -289,10 +289,8 @@ static int vt8500lcd_probe(struct platform_device *pdev)
>
> fbi = devm_kzalloc(&pdev->dev, sizeof(struct vt8500lcd_info)
> + sizeof(u32) * 16, GFP_KERNEL);
> - if (!fbi) {
> - dev_err(&pdev->dev, "Failed to initialize framebuffer device\n");
> + if (!fbi)
> return -ENOMEM;
> - }
>
This removes the information about the device for which the allocation
fails (but as there can be only one vt8500lcdfb device in the system this
change is okay).
Patch queued for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-29 17:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20171124195318epcas2p1b030ce8d47da92659b3c6068c0810778@epcas2p1.samsung.com>
2017-11-24 19:53 ` [PATCH] video/fbdev/vt8500lcdfb: Delete an error message for a failed memory allocation in vt8500lcd SF Markus Elfring
2017-12-29 17:53 ` [PATCH] video/fbdev/vt8500lcdfb: Delete an error message for a failed memory allocation in vt850 Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).