From: Thomas Zimmermann <tzimmermann@suse.de>
To: Helge Deller <deller@gmx.de>, Gerd Hoffmann <kraxel@redhat.com>
Cc: linux-fbdev@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Sam Ravnborg <sam@ravnborg.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sven Schnelle <svens@stackframe.org>,
Javier Martinez Canillas <javierm@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Claudio Suarez <cssk@net-c.es>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"
Date: Mon, 24 Jan 2022 12:33:21 +0100 [thread overview]
Message-ID: <d23800b4-503c-a6e2-2c51-2c07a736dffc@suse.de> (raw)
In-Reply-To: <64fd46cb-9746-3fd0-ec92-c64dba76875a@gmx.de>
[-- Attachment #1.1: Type: text/plain, Size: 1665 bytes --]
Hi
Am 24.01.22 um 12:10 schrieb Helge Deller:
[...]
>
> Here is my proposed way forward:
> a) I will resend the patches which reverts the remove-fbcon-hardware-scolling patches
> to the mailing lists. I'll adjust the stable tags and update the commit messages.
> b) Then after some days I'll include it in the fbdev for-next git branch. That way it's
> included in the various build & test chains.
> c) If everything is working well, I'll push that change during the next merge window
> for kernel 5.18. If problems arise we will need to discuss.
>
> While the patches are in the fbdev git tree we should decide how to exclude code
> which is not needed for DRM.
>
> What about this proposal:
> a) adding a Kconfig option like:
> CONFIG_FB_DRIVERS - enable if you need the fbdev drivers. For DRM-only this should be disabled.
> b) Add to every native fbdev driver a "depends on FB_DRIVERS" in the Kconfig files.
> c) That way we can use "#if defined(CONFIG_FB_DRIVERS).." to exclude code in fbcon which
> isn't needed by DRM.
>
> Thoughts?
I can't say I approve keeping fbdev alive, but...
With fbdev emulation, every DRM driver is an fbdev driver too. So
CONFIG_FB_DRIVER is somewhat misleading. Better add an option like
CONFIG_FBCON_HW_SCROLLING and have it selected by the fbdev drivers that
absolutely need HW acceleration. That option would then protect the rsp
code.
Best regards
Thomas
>
> Helge
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2022-01-24 11:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 11:08 [PATCH 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon Helge Deller
2022-01-19 11:08 ` [PATCH 1/2] Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)" Helge Deller
2022-01-19 11:08 ` [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling" Helge Deller
2022-01-19 11:22 ` Greg Kroah-Hartman
2022-01-19 11:28 ` Greg Kroah-Hartman
2022-01-19 11:47 ` Geert Uytterhoeven
2022-01-19 12:28 ` Helge Deller
2022-01-19 14:01 ` Linus Torvalds
2022-01-19 14:11 ` Helge Deller
2022-01-19 14:34 ` Daniel Vetter
2022-01-19 15:05 ` Sven Schnelle
2022-01-19 15:37 ` Thomas Zimmermann
2022-01-19 16:55 ` Helge Deller
2022-01-19 15:42 ` Daniel Vetter
2022-01-19 15:54 ` Helge Deller
2022-01-19 16:13 ` Jani Nikula
2022-01-19 16:31 ` Daniel Vetter
2022-01-19 15:18 ` Helge Deller
2022-01-19 13:01 ` Sven Schnelle
2022-01-19 13:35 ` Greg Kroah-Hartman
2022-01-20 14:30 ` Daniel Vetter
2022-01-20 17:01 ` Helge Deller
2022-01-21 7:20 ` Gerd Hoffmann
2022-01-24 11:10 ` Helge Deller
2022-01-24 11:28 ` Javier Martinez Canillas
2022-01-24 11:33 ` Thomas Zimmermann [this message]
2022-01-24 11:50 ` Javier Martinez Canillas
2022-01-24 15:29 ` Helge Deller
2022-01-24 15:45 ` Thomas Zimmermann
2022-01-24 15:50 ` Geert Uytterhoeven
2022-01-24 15:58 ` Daniel Vetter
2022-01-24 15:50 ` Geert Uytterhoeven
2022-01-24 16:11 ` Thomas Zimmermann
2022-01-19 12:45 ` [PATCH 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon Geert Uytterhoeven
2022-01-19 13:02 ` Sven Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d23800b4-503c-a6e2-2c51-2c07a736dffc@suse.de \
--to=tzimmermann@suse.de \
--cc=cssk@net-c.es \
--cc=daniel.vetter@intel.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sam@ravnborg.org \
--cc=svens@stackframe.org \
--cc=tomi.valkeinen@ti.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).