Re: [PATCH v3 3/6] fbdev: au1100fb: Use %zu to printk a value of type size_t

[Helge Deller <deller@gmx.de>]

On 2/8/26 20:21, Helge Deller wrote:
> On 2/8/26 18:58, Uwe Kleine-König wrote:
>> %zu is the dedicated type for size_t. %d only works on 32bit
>> architectures where size_t is typedef'd to be unsigned int. (And then
>> the signedness doesn't fit, but `gcc -Wformat` doesn't stumble over this.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
>> ---
>>   drivers/video/fbdev/au1100fb.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
>> index b1da51683de7..914f371a614c 100644
>> --- a/drivers/video/fbdev/au1100fb.c
>> +++ b/drivers/video/fbdev/au1100fb.c
>> @@ -439,7 +439,7 @@ static int au1100fb_drv_probe(struct platform_device *dev)
>>       fbdev->regs = (struct au1100fb_regs*)KSEG1ADDR(fbdev->info.fix.mmio_start);
>>       print_dbg("Register memory map at %p", fbdev->regs);
>> -    print_dbg("phys=0x%08x, size=%d", fbdev->regs_phys, fbdev->regs_len);
>> +    print_dbg("phys=0x%08x, size=%zu", fbdev->regs_phys, fbdev->regs_len);
>>       c = clk_get(NULL, "lcd_intclk");
>>       if (!IS_ERR(c)) {
>> @@ -456,7 +456,7 @@ static int au1100fb_drv_probe(struct platform_device *dev)
>>                           PAGE_ALIGN(fbdev->fb_len),
>>                           &fbdev->fb_phys, GFP_KERNEL);
>>       if (!fbdev->fb_mem) {
>> -        print_err("fail to allocate framebuffer (size: %dK))",
>> +        print_err("fail to allocate framebuffer (size: %zuK))",
>>                 fbdev->fb_len / 1024);
>>           return -ENOMEM;
>>       }
>> @@ -465,7 +465,7 @@ static int au1100fb_drv_probe(struct platform_device *dev)
>>       fbdev->info.fix.smem_len = fbdev->fb_len;
>>       print_dbg("Framebuffer memory map at %p", fbdev->fb_mem);
>> -    print_dbg("phys=0x%08x, size=%dK", fbdev->fb_phys, fbdev->fb_len / 1024);
>> +    print_dbg("phys=0x%08x, size=%zuK", &fbdev->fb_phys, fbdev->fb_len / 1024);
> 
> The & seems to be wrong.

I see you fix it up in patch #4.
Maybe simply merge them?

Helge