* [PATCH] video: fbdev: sis: use explicitly signed char
@ 2022-10-24 16:29 Jason A. Donenfeld
2022-10-24 18:29 ` Helge Deller
2022-10-25 9:59 ` David Laight
0 siblings, 2 replies; 5+ messages in thread
From: Jason A. Donenfeld @ 2022-10-24 16:29 UTC (permalink / raw)
To: linux-kernel
Cc: Jason A. Donenfeld, Thomas Winischhofer, Greg Kroah-Hartman,
Helge Deller, linux-usb, linux-fbdev, dri-devel
With char becoming unsigned by default, and with `char` alone being
ambiguous and based on architecture, signed chars need to be marked
explicitly as such. This fixes warnings like:
drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: 'SiS_Pr->SiS_EModeIDTable[ModeIdIndex]->ROMMODEIDX661' is unsigned
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-usb@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/usb/misc/sisusbvga/sisusb_struct.h | 2 +-
drivers/video/fbdev/sis/vstruct.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb_struct.h b/drivers/usb/misc/sisusbvga/sisusb_struct.h
index 3df64d2a9d43..a86032a26d36 100644
--- a/drivers/usb/misc/sisusbvga/sisusb_struct.h
+++ b/drivers/usb/misc/sisusbvga/sisusb_struct.h
@@ -91,7 +91,7 @@ struct SiS_Ext {
unsigned char VB_ExtTVYFilterIndex;
unsigned char VB_ExtTVYFilterIndexROM661;
unsigned char REFindex;
- char ROMMODEIDX661;
+ signed char ROMMODEIDX661;
};
struct SiS_Ext2 {
diff --git a/drivers/video/fbdev/sis/vstruct.h b/drivers/video/fbdev/sis/vstruct.h
index ea94d214dcff..d7a14e63ba5a 100644
--- a/drivers/video/fbdev/sis/vstruct.h
+++ b/drivers/video/fbdev/sis/vstruct.h
@@ -148,7 +148,7 @@ struct SiS_Ext {
unsigned char VB_ExtTVYFilterIndex;
unsigned char VB_ExtTVYFilterIndexROM661;
unsigned char REFindex;
- char ROMMODEIDX661;
+ signed char ROMMODEIDX661;
};
struct SiS_Ext2 {
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] video: fbdev: sis: use explicitly signed char
2022-10-24 16:29 [PATCH] video: fbdev: sis: use explicitly signed char Jason A. Donenfeld
@ 2022-10-24 18:29 ` Helge Deller
2022-10-25 12:55 ` Jason A. Donenfeld
2022-10-25 9:59 ` David Laight
1 sibling, 1 reply; 5+ messages in thread
From: Helge Deller @ 2022-10-24 18:29 UTC (permalink / raw)
To: Jason A. Donenfeld, linux-kernel
Cc: Thomas Winischhofer, Greg Kroah-Hartman, linux-usb, linux-fbdev,
dri-devel
On 10/24/22 18:29, Jason A. Donenfeld wrote:
> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, signed chars need to be marked
> explicitly as such. This fixes warnings like:
>
> drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: 'SiS_Pr->SiS_EModeIDTable[ModeIdIndex]->ROMMODEIDX661' is unsigned
>
> Cc: Thomas Winischhofer <thomas@winischhofer.net>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Applied to linux-fbdev git tree.
Thanks,
Helge
> ---
> drivers/usb/misc/sisusbvga/sisusb_struct.h | 2 +-
> drivers/video/fbdev/sis/vstruct.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/misc/sisusbvga/sisusb_struct.h b/drivers/usb/misc/sisusbvga/sisusb_struct.h
> index 3df64d2a9d43..a86032a26d36 100644
> --- a/drivers/usb/misc/sisusbvga/sisusb_struct.h
> +++ b/drivers/usb/misc/sisusbvga/sisusb_struct.h
> @@ -91,7 +91,7 @@ struct SiS_Ext {
> unsigned char VB_ExtTVYFilterIndex;
> unsigned char VB_ExtTVYFilterIndexROM661;
> unsigned char REFindex;
> - char ROMMODEIDX661;
> + signed char ROMMODEIDX661;
> };
>
> struct SiS_Ext2 {
> diff --git a/drivers/video/fbdev/sis/vstruct.h b/drivers/video/fbdev/sis/vstruct.h
> index ea94d214dcff..d7a14e63ba5a 100644
> --- a/drivers/video/fbdev/sis/vstruct.h
> +++ b/drivers/video/fbdev/sis/vstruct.h
> @@ -148,7 +148,7 @@ struct SiS_Ext {
> unsigned char VB_ExtTVYFilterIndex;
> unsigned char VB_ExtTVYFilterIndexROM661;
> unsigned char REFindex;
> - char ROMMODEIDX661;
> + signed char ROMMODEIDX661;
> };
>
> struct SiS_Ext2 {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] video: fbdev: sis: use explicitly signed char
2022-10-24 18:29 ` Helge Deller
@ 2022-10-25 12:55 ` Jason A. Donenfeld
2022-10-25 13:00 ` Helge Deller
0 siblings, 1 reply; 5+ messages in thread
From: Jason A. Donenfeld @ 2022-10-25 12:55 UTC (permalink / raw)
To: Helge Deller
Cc: linux-kernel, Thomas Winischhofer, Greg Kroah-Hartman, linux-usb,
linux-fbdev, dri-devel
On Mon, Oct 24, 2022 at 8:29 PM Helge Deller <deller@gmx.de> wrote:
>
> On 10/24/22 18:29, Jason A. Donenfeld wrote:
> > With char becoming unsigned by default, and with `char` alone being
> > ambiguous and based on architecture, signed chars need to be marked
> > explicitly as such. This fixes warnings like:
> >
> > drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: 'SiS_Pr->SiS_EModeIDTable[ModeIdIndex]->ROMMODEIDX661' is unsigned
> >
> > Cc: Thomas Winischhofer <thomas@winischhofer.net>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Helge Deller <deller@gmx.de>
> > Cc: linux-usb@vger.kernel.org
> > Cc: linux-fbdev@vger.kernel.org
> > Cc: dri-devel@lists.freedesktop.org
> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
>
> Applied to linux-fbdev git tree.
For 6.1 as a fix, right? Since this is already broken on, e.g., ARM.
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] video: fbdev: sis: use explicitly signed char
2022-10-25 12:55 ` Jason A. Donenfeld
@ 2022-10-25 13:00 ` Helge Deller
0 siblings, 0 replies; 5+ messages in thread
From: Helge Deller @ 2022-10-25 13:00 UTC (permalink / raw)
To: Jason A. Donenfeld
Cc: linux-kernel, Thomas Winischhofer, Greg Kroah-Hartman, linux-usb,
linux-fbdev, dri-devel
On 10/25/22 14:55, Jason A. Donenfeld wrote:
> On Mon, Oct 24, 2022 at 8:29 PM Helge Deller <deller@gmx.de> wrote:
>>
>> On 10/24/22 18:29, Jason A. Donenfeld wrote:
>>> With char becoming unsigned by default, and with `char` alone being
>>> ambiguous and based on architecture, signed chars need to be marked
>>> explicitly as such. This fixes warnings like:
>>>
>>> drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: 'SiS_Pr->SiS_EModeIDTable[ModeIdIndex]->ROMMODEIDX661' is unsigned
>>>
>>> Cc: Thomas Winischhofer <thomas@winischhofer.net>
>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> Cc: Helge Deller <deller@gmx.de>
>>> Cc: linux-usb@vger.kernel.org
>>> Cc: linux-fbdev@vger.kernel.org
>>> Cc: dri-devel@lists.freedesktop.org
>>> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
>>
>> Applied to linux-fbdev git tree.
>
> For 6.1 as a fix, right? Since this is already broken on, e.g., ARM.
Yes.
Helge
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] video: fbdev: sis: use explicitly signed char
2022-10-24 16:29 [PATCH] video: fbdev: sis: use explicitly signed char Jason A. Donenfeld
2022-10-24 18:29 ` Helge Deller
@ 2022-10-25 9:59 ` David Laight
1 sibling, 0 replies; 5+ messages in thread
From: David Laight @ 2022-10-25 9:59 UTC (permalink / raw)
To: 'Jason A. Donenfeld', linux-kernel@vger.kernel.org
Cc: Thomas Winischhofer, Greg Kroah-Hartman, Helge Deller,
linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org
From: Jason A. Donenfeld
> Sent: 24 October 2022 17:29
> To: linux-kernel@vger.kernel.org
>
> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, signed chars need to be marked
> explicitly as such. This fixes warnings like:
>
...
> ---
> drivers/usb/misc/sisusbvga/sisusb_struct.h | 2 +-
> drivers/video/fbdev/sis/vstruct.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/misc/sisusbvga/sisusb_struct.h b/drivers/usb/misc/sisusbvga/sisusb_struct.h
> index 3df64d2a9d43..a86032a26d36 100644
> --- a/drivers/usb/misc/sisusbvga/sisusb_struct.h
> +++ b/drivers/usb/misc/sisusbvga/sisusb_struct.h
> @@ -91,7 +91,7 @@ struct SiS_Ext {
> unsigned char VB_ExtTVYFilterIndex;
> unsigned char VB_ExtTVYFilterIndexROM661;
> unsigned char REFindex;
> - char ROMMODEIDX661;
> + signed char ROMMODEIDX661;
Isn't the correct fix to use u8 and s8 ?
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-25 13:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24 16:29 [PATCH] video: fbdev: sis: use explicitly signed char Jason A. Donenfeld
2022-10-24 18:29 ` Helge Deller
2022-10-25 12:55 ` Jason A. Donenfeld
2022-10-25 13:00 ` Helge Deller
2022-10-25 9:59 ` David Laight
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).