From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56674C433F5 for ; Wed, 9 Mar 2022 13:16:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233041AbiCINRZ (ORCPT ); Wed, 9 Mar 2022 08:17:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230048AbiCINRZ (ORCPT ); Wed, 9 Mar 2022 08:17:25 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 83A30177766 for ; Wed, 9 Mar 2022 05:16:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646831785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9L4wXSzrzpGMIVEQW9rtUhalBtem2aX0icrd1WDGeA0=; b=TkP7KNWluANN8eo7El/ggpBqaotJA48FRSHZmko3g6GOdHCgSMV736ezgKTyOnocJ5UOCs 5JjCpqvfvPfx57wQ3zYo2w1hgYXNxKXbCKdNcIrsq397ppfHI3fH38/CQv/dQdnnIfx8Qz fPdwgZjwK2+1j0o3/sOeA9SpUEx3tFw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-664-eVAAxngPPNu6y9T4z1Y0Bw-1; Wed, 09 Mar 2022 08:16:24 -0500 X-MC-Unique: eVAAxngPPNu6y9T4z1Y0Bw-1 Received: by mail-wr1-f69.google.com with SMTP id t8-20020adfa2c8000000b001e8f6889404so755199wra.0 for ; Wed, 09 Mar 2022 05:16:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9L4wXSzrzpGMIVEQW9rtUhalBtem2aX0icrd1WDGeA0=; b=zJhxJQZKTbc+Hf7w9Or8KKuX2DYV+zjCrFPQrgbLffpwFOjAff0nHQ/emIQhME9Gkv gOjSb4OmwLUy5yDYvh3QfMZN1WBQRcVRIfy70IgtWV525Z2hc5hx7XHxus5U+PZj8hTu fkHt3u/l0uebMpgjZYOG3AtzOufQDlCnrq5bwsLRYQwegLM4fPTaCcgVU32dJ4O1/feT pjFnO95Y7w81Yuqm2Mmbjy3sdCfPqlu3MTb/dnnXtExa3/5iwsqd6ALRKbI9n/P95/1v o7A+9dUG81E8Xy5pzyRj+PCUluINfD+Fr5L+ZFN4PCbn46pkkdbpH71LOu17Qs/NwEhn fc6w== X-Gm-Message-State: AOAM533Y7ESd3FGKIUyLH4fxu3A+DjZD0ixDKFGKBwaT9no8p1Tr/VAt shpq4zbJfHHHNGGgHmO+QKGTFEZz3VDapWHfL9F/vbktfvm/Y5O25fj+L18lS5xvU9Mxh1MqZwK 6jpTI+vOX1KZUOSEr57Bs6yQ= X-Received: by 2002:a1c:a4c6:0:b0:389:7269:5044 with SMTP id n189-20020a1ca4c6000000b0038972695044mr3162291wme.129.1646831782861; Wed, 09 Mar 2022 05:16:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJyLVGtK4mTCwqDFDUxuBL3MHtSqW+jHIdMFxcBe9+YpVz8cxRLKpK8ygkT8GVaau+FzvEgBlw== X-Received: by 2002:a1c:a4c6:0:b0:389:7269:5044 with SMTP id n189-20020a1ca4c6000000b0038972695044mr3162281wme.129.1646831782620; Wed, 09 Mar 2022 05:16:22 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id t184-20020a1c46c1000000b003814de297fcsm4964440wma.16.2022.03.09.05.16.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Mar 2022 05:16:19 -0800 (PST) Message-ID: Date: Wed, 9 Mar 2022 14:16:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 RFC 07/10] drm/gem-fb-helper: Use actual bpp for size calculations Content-Language: en-US To: Geert Uytterhoeven , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sam Ravnborg , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org References: <842ab0a286ff743b625277e655d9bef505b630c1.1646683502.git.geert@linux-m68k.org> From: Javier Martinez Canillas In-Reply-To: <842ab0a286ff743b625277e655d9bef505b630c1.1646683502.git.geert@linux-m68k.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 3/7/22 21:52, Geert Uytterhoeven wrote: > The AFBC helpers derive the number of bits per pixel from the deprecated > drm_format_info.cpp[] field, which does not take into account block > sizes. > > Fix this by using the actual number of bits per pixel instead. > > Signed-off-by: Geert Uytterhoeven > --- > RFC, as this code path was untested. > Looks good to me but haven't tested either. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat