From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A5C7C7EE24 for ; Tue, 6 Jun 2023 05:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232154AbjFFF0f (ORCPT ); Tue, 6 Jun 2023 01:26:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232274AbjFFF0b (ORCPT ); Tue, 6 Jun 2023 01:26:31 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C3A7E43 for ; Mon, 5 Jun 2023 22:26:27 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3f736e0c9b1so25197015e9.3 for ; Mon, 05 Jun 2023 22:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686029186; x=1688621186; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dDsCLYgxw0cAllMIv7aPZnktih/2jRXLUmlxWaBI1IA=; b=IwxvokNMCgzhhXOUSzqxqBgRxmi+htg/TlgMk4ZYeM32beHp0ygBO8euxAR0AQm+1o c41sqH0a03Ang8oPH4q5RE2TIZ7EzDBicWi5Upqo1LS+VH8cHLDoXkXA27jwp8wo48rf eZmiyl/UL9g3tnTKk1UqirKGm7+TsJwBv75CZSJH9zuV9IOtgE6Ar+SpSBJxi9gqZ6mz BpNyY5nVfJPTkaELNR9yt+4F16iw3qCLjesDjgrzXMwNg4ryEavCgFDHvFNOiEnpPwU9 qlbDzpvSAdN661d7mnDQUfmS53+gK8Qv4j+Yvm6y3AX2CWfAiZFODcAcPaKId8yVzZ1t 9Olg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686029186; x=1688621186; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dDsCLYgxw0cAllMIv7aPZnktih/2jRXLUmlxWaBI1IA=; b=bgqTCxL6K+5nW6bG/qWeDuKayHebhb5NPCDFuOw3a0LTS3ocbJRNI9MaOELAp4fH+J T4DUMI8SpQFizHf+1iaBnRcz1UgnnxWrk1hMhebrpePvHDAJP4fUtI/qFBDAPiD6wY6d mrfEOUkUcniMovvzLyuhlG8PGL/XZ3MVhLmoGdBdF1w+Jxa39s3MAOF0DC8aGjrusY7M vfiTPMiKUeRwzUn4ygK9PcAJPaGcWSzLKmb3K7NrRuiToRJ194qZ85Slglo6kf25uo6c a64QhGUog+8Q4H64t9tGUO6O8lH+Gy3mE817WDWiz2iSHEklznBPORijS9h8vdRchZwI PTZg== X-Gm-Message-State: AC+VfDyWIeWHsfqwZ464QZxf/nI4T65ombcKXyawm6SH7N2ZoUoCSSIh VtnVknZ4g/T/MlcSrE5tYsyOTA== X-Google-Smtp-Source: ACHHUZ7O2HWP67RgSNqCAyjbTAYsyzDWwhj4EAisp0m7UY5KYbL/2OK6vhedUYAPw7jtmm/0lF9awg== X-Received: by 2002:a7b:cc8e:0:b0:3f6:766:f76f with SMTP id p14-20020a7bcc8e000000b003f60766f76fmr979213wma.36.1686029185900; Mon, 05 Jun 2023 22:26:25 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id f18-20020a1cc912000000b003f4e3ed98ffsm12686196wmb.35.2023.06.05.22.26.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 22:26:23 -0700 (PDT) Date: Tue, 6 Jun 2023 08:26:19 +0300 From: Dan Carpenter To: Thomas Zimmermann Cc: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 11/30] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev Message-ID: References: <20230605144812.15241-1-tzimmermann@suse.de> <20230605144812.15241-12-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230605144812.15241-12-tzimmermann@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Mon, Jun 05, 2023 at 04:47:53PM +0200, Thomas Zimmermann wrote: > Do not assing the Linux device to struct fb_info.dev. The call to > register_framebuffer() initializes the field to the fbdev device. > Drivers should not override its value. > > Fixes a bug where the driver incorrectly decreases the hardware > device's reference counter and leaks the fbdev device. > > Signed-off-by: Thomas Zimmermann Fixes: 88017bda96a5 ("ep93xx video driver") regards, dan carpenter