Re: [PATCH stable] fbdev: Fix out-of-bounds issue in sys_fillrect()

[Gu Bowen <gubowen5@huawei.com>]

On 12/3/2025 4:05 AM, Helge Deller wrote:
> Backporting commit eabb03293087 to 6.6 seems unrealistic.
> So, maybe adding your patch to stable might make sense.
> 
> +    if (dst_offset < 0 || dst_offset >= p->fix.smem_len) {
> +        pr_err("dst offset out of bound: dst_offset(%ld)", dst_offset);
> +        return;
> 
> I don't like the pr_err() in here. I do understand that you want to print
> that something wrong happened, but we are inside the console printing code.
> I think we should just return in this case.
> 

Oh, you are right, I should not add pr_err() in here. Maybe we can use 
pr_info_once() instead if you don't mind.
I will send a new patch until I receive your feedback. Thanks!

BR,
Guber