From: Helge Deller <deller@gmx.de>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: "Thomas Zimmermann" <tzimmermann@suse.de>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Yang Yang" <yang.yang29@zte.com>,
"Xu Panda" <xu.panda@zte.com.cn>,
"Lucy Mielke" <mielkesteven@icloud.com>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fbdev: omapfb: fix some error codes
Date: Mon, 16 Oct 2023 23:09:05 +0200 [thread overview]
Message-ID: <e1c6a19b-7587-4b99-b8d5-5572d946f185@gmx.de> (raw)
In-Reply-To: <843b063c-ee4a-4e17-add6-75e2cc82c2f4@moroto.mountain>
On 10/16/23 13:19, Dan Carpenter wrote:
> Return negative -ENXIO instead of positive ENXIO.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
applied.
Thanks!
Helge
> ---
> No fixes tag because the caller doesn't check for errors.
>
> drivers/video/fbdev/omap/omapfb_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
> index f28cb90947a3..42c96f1cfc93 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -1645,13 +1645,13 @@ static int omapfb_do_probe(struct platform_device *pdev,
> }
> fbdev->int_irq = platform_get_irq(pdev, 0);
> if (fbdev->int_irq < 0) {
> - r = ENXIO;
> + r = -ENXIO;
> goto cleanup;
> }
>
> fbdev->ext_irq = platform_get_irq(pdev, 1);
> if (fbdev->ext_irq < 0) {
> - r = ENXIO;
> + r = -ENXIO;
> goto cleanup;
> }
>
prev parent reply other threads:[~2023-10-16 21:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 11:19 [PATCH] fbdev: omapfb: fix some error codes Dan Carpenter
2023-10-16 21:09 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1c6a19b-7587-4b99-b8d5-5572d946f185@gmx.de \
--to=deller@gmx.de \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mielkesteven@icloud.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=xu.panda@zte.com.cn \
--cc=yang.yang29@zte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox