From: Helge Deller <deller@gmx.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Atul Raut" <rauji.raut@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
kernel@pengutronix.de,
linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH 01/22] fb: amifb: Stop using platform_driver_probe()
Date: Thu, 9 Nov 2023 21:31:08 +0100 [thread overview]
Message-ID: <e2f7ef76-7c03-40d6-a985-141dc1a191c2@gmx.de> (raw)
In-Reply-To: <CAMuHMdVsHHPAE5JXjC5rS86H=nDgBMePGU8b1y_wcQYrWZHuTA@mail.gmail.com>
On 11/8/23 22:34, Geert Uytterhoeven wrote:
> Hi Helge,
>
> On Wed, Nov 8, 2023 at 10:32 PM Helge Deller <deller@gmx.de> wrote:
>> On 11/8/23 22:06, Geert Uytterhoeven wrote:
>>> On Tue, Nov 7, 2023 at 10:20 AM Uwe Kleine-König
>>> <u.kleine-koenig@pengutronix.de> wrote:
>>>> On today's platforms the benefit of platform_driver_probe() isn't that
>>>> relevant any more. It allows to drop some code after booting (or module
>>>> loading) for .probe() and discard the .remove() function completely if
>>>> the driver is built-in. This typically saves a few 100k.
>>>
>>> Which is a lot on platforms with only a few MiBs of RAM...
>>
>> True.
>> Given the warnings below, what is your suggestion?
>> Better to drop the amifb patch ?
>
> I think so. There is a reason these drivers use platform_driver_probe().
Ok, I've dropped both amifb patches.
Helge
next prev parent reply other threads:[~2023-11-09 20:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 9:17 [PATCH 00/22] fb: handle remove callbacks in .exit.text and convert to .remove_new Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 01/22] fb: amifb: Stop using platform_driver_probe() Uwe Kleine-König
2023-11-08 21:06 ` Geert Uytterhoeven
2023-11-08 21:32 ` Helge Deller
2023-11-08 21:34 ` Geert Uytterhoeven
2023-11-09 20:31 ` Helge Deller [this message]
2023-11-07 9:17 ` [PATCH 02/22] fb: atmel_lcdfb: " Uwe Kleine-König
2023-11-07 20:01 ` Uwe Kleine-König
2023-11-07 20:37 ` Helge Deller
2023-11-08 18:48 ` Nathan Chancellor
2023-11-08 20:27 ` Helge Deller
2023-11-08 21:00 ` Uwe Kleine-König
2023-11-08 21:24 ` Helge Deller
2023-11-08 21:52 ` Uwe Kleine-König
2023-11-08 21:57 ` Helge Deller
2023-11-09 6:24 ` Uwe Kleine-König
2023-11-09 9:55 ` Helge Deller
2023-11-09 10:20 ` Nicolas Ferre
2023-11-09 10:32 ` Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 03/22] fb: omapfb/analog-tv: Don't put .remove() in .exit.text and drop suppress_bind_attrs Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 04/22] fb: omapfb/dpi: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 05/22] fb: omapfb/dsi-cm: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 06/22] fb: omapfb/dvi: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 07/22] fb: omapfb/hdmi: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 08/22] fb: omapfb/opa362: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 09/22] fb: omapfb/sharp-ls037v7dw01: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 10/22] fb: omapfb/tfp410: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 11/22] fb: omapfb/tpd12s015: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 12/22] fb: amifb: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 13/22] fb: atmel_lcdfb: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 14/22] fb: omapfb/analog-tv: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 15/22] fb: omapfb/dpi: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 16/22] fb: omapfb/dsi-cm: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 17/22] fb: omapfb/dvi: " Uwe Kleine-König
2023-11-07 9:17 ` [PATCH 18/22] fb: omapfb/hdmi: " Uwe Kleine-König
2023-11-07 9:18 ` [PATCH 19/22] fb: omapfb/opa362: " Uwe Kleine-König
2023-11-07 9:18 ` [PATCH 20/22] fb: omapfb/sharp-ls037v7dw01: " Uwe Kleine-König
2023-11-07 9:18 ` [PATCH 21/22] fb: omapfb/tfp410: " Uwe Kleine-König
2023-11-07 9:18 ` [PATCH 22/22] fb: omapfb/tpd12s015: " Uwe Kleine-König
2023-11-07 13:57 ` [PATCH 00/22] fb: handle remove callbacks in .exit.text and convert to .remove_new Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2f7ef76-7c03-40d6-a985-141dc1a191c2@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=rauji.raut@gmail.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox