Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Chen Ni" <nichen@iscas.ac.cn>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Helge Deller" <deller@gmx.de>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fbdev: au1100fb: Add missing check for clk_enable
Date: Wed, 28 Jan 2026 10:40:33 +0100	[thread overview]
Message-ID: <e46c9f31-6991-454b-aedd-10c10fc482a0@web.de> (raw)
In-Reply-To: <20260128091004.2747011-1-nichen@iscas.ac.cn>

> Add check for the return value of clk_enable() andreturn the error

                                                 and return?


> if it fails in order to catch the error.

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc7#n145

Regards,
Markus

  reply	other threads:[~2026-01-28  9:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28  9:10 [PATCH] fbdev: au1100fb: Add missing check for clk_enable Chen Ni
2026-01-28  9:40 ` Markus Elfring [this message]
2026-01-28 13:29 ` Helge Deller
2026-01-28 14:55   ` Uwe Kleine-König
2026-01-29  4:07     ` [PATCH v2] fbdev: au1100fb: Check return value of clk_enable() in .resume() Chen Ni
2026-01-29  7:13       ` Uwe Kleine-König
2026-01-29  7:45         ` Helge Deller
2026-01-29  7:36       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e46c9f31-6991-454b-aedd-10c10fc482a0@web.de \
    --to=markus.elfring@web.de \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nichen@iscas.ac.cn \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox