From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F7BD1FECB0 for ; Wed, 25 Jun 2025 11:19:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750850388; cv=none; b=cZdUrBdtPeS2x+jfgQzBqIZYU7is/v29X5ZvAvDxX8gVnahw0j980r+O0YMR1nr+yRLoxXltR0SdyLTkDMpTSTd/zNxUhQYCP+StdrvaKaf2iV6SVWHnvPCzoN6PNVaVwofsxqdaCjphDZ6mXidagra3wjQoRxECwe1WZH/Ohx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750850388; c=relaxed/simple; bh=VNz+lSy568xXrNEW/LdsAyCYu0exIyy51MijlASqERI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gC4Yz0g8qhe4r8J7aagSC5D9yPqpOfbeN+pecwm85Zu9EhV5vhgi0vOxXXi/oOxMFELDlAoPX2aSJKby6Q/XJWWIYVbjN4Wn2vSmq913jTMv6tbhz1zL+Y9b5+n/usJVZtUOWyzJsLPRFO6NHaExoG8QBDLrQAnjH2wuwEaFA7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RC0Go2XJ; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RC0Go2XJ" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-72c14138668so397147a34.2 for ; Wed, 25 Jun 2025 04:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750850386; x=1751455186; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iq4wYZ8O8v8iGoHVKCZbSBs74G20nkHHqtB4OQv75Kk=; b=RC0Go2XJZoD2w9YPxoKoro2XpHEqF+1b5xeqdcMsIfB8KxSTHPl+yEaXv/ndqkxdgb rPvi2fJgcJBLEdmQNmmuKmecCLxUqbbf6LwF5SQNrXGvTi6oAWGs501Nl7/gwek40IVv weMj8/cEyefme9fnHqbq28HMMakgbdO6R5IOqyeN5fdOVSHwvIa3sBA26HCgDaQ5YpgR Qn+gzry9zdkSwFnji72w/GPvCtk5PNUbSU7+QH/T+1PwjeVo7u7Nb0PcL9GqhAtQnvUq hECmvSlDAMWPAb7HJtn2hT1lGBRfJKhfbRA6+bXMs0+dFMZp1upB72NTXpxwenO6yibh V1HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750850386; x=1751455186; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iq4wYZ8O8v8iGoHVKCZbSBs74G20nkHHqtB4OQv75Kk=; b=MO2YUzvjQXCV3tLA+rnKFyhZjN9qPU+MR4MX7/v/5h+hW2/nos2wr6csDpTzWYnaUm xV/3jg3ytRdzyi2CBq34JXLEeKU7Xed9woPtjzkUQ+ngfU+qJfC9WIlkjdXHIpfuHRys I8Ii3GI0HIKhSWYc3B/dtWF3TTK5JilzTMH672bBhsUqxemwTWybJaQ0pdM+EtT+Cz4j bULsw45n1qaze1pnoA5yiRNTGOfdPvHKQhWUmyPCw/9/D5zzkjZBUhBlGQyyrStI9OIp ONELqURkhltMCk77pHlcEiMF3G7DJxe1cm5VEWZg1F6LQKGFUEVq2RBJ1dIX3jXq9fgO nawQ== X-Forwarded-Encrypted: i=1; AJvYcCWkZ9kKpU2s2ZPD4oiU0cd1icLx1Dagc5XqjECIwoAjy/kEctgR6RU4c31hQTY8wMh4e6RmwvgldMdQAg==@vger.kernel.org X-Gm-Message-State: AOJu0Yyi08Tddx4kJr7R+navdxY9sZ5iWUGDMfIw6nUq7VN10xVLxu+j zu+CbPI/nY9fbS+ueXbGwDr0CBpgcXsnPVM79io2nw7GNL3EnvNaUBZ3j2SiHkA35Jc= X-Gm-Gg: ASbGncv0i77RjYbPjcldrdVyaXCesxckOj0lxL5w9blJfxYO8EjrRSClnsDh1pU1rBP OylGEV2i9XrUgElzCj/m1TUPP6DmsgshuyJcTIgalvuK0n/YWKDwcdPA6AxzCpfnZShsevhBp6R GFBZylGG49xjGW6YXnPs4aghe5vcWFzIKYYkU1LY2bSy8IdQoA30LJAc7cklCna4U+MdlMb/pRW UIgYGIiMN8HsPMRuLqLsEzJV//+QAZqrYBFoRa5p65QP0z98OdcMnq4ZubzVRgT2pkGA+5yKx/4 BbsPA4DN9EgV1NIzqhevtRYL0wYsH5MQt/V3OBsr9GVb+qpeYSwsP/I/8NGA4BVGP3NydI3o54w GsS52 X-Google-Smtp-Source: AGHT+IHUPmQyLG5EAp7kEhFfGkI4eD9tbFqoGyW5KZup0EXS2PDOGnB5h/POMmLnHUjyUistd5gdNg== X-Received: by 2002:a05:6830:4429:b0:72c:3235:3b97 with SMTP id 46e09a7af769-73adc8984e6mr1795836a34.22.1750850386145; Wed, 25 Jun 2025 04:19:46 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:22c9:dcd3:f442:dd1d]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6117598cc6bsm989956eaf.32.2025.06.25.04.19.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 04:19:44 -0700 (PDT) Date: Wed, 25 Jun 2025 14:19:42 +0300 From: Dan Carpenter To: Pratibimba Khadka Cc: sudipm.mukherjee@gmail.com, Teddy Wang , Greg Kroah-Hartman , "open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER" , "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH] staging: sm750fb: Mark g_fbmode as a pointer to const pointer Message-ID: References: <20250625045526.82758-1-pratibimbakhadka@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250625045526.82758-1-pratibimbakhadka@gmail.com> On Wed, Jun 25, 2025 at 10:40:26AM +0545, Pratibimba Khadka wrote: > Fixes a checkpatch warning: > WARNING: static const char * array should probably be static const char * const > > The array `g_fbmode` contains constant string pointers that are not > supposed to be modified. By declaring it as `const char * const`, > both the string literals and the pointers themselves are protected > from accidental modification, which improves code safety and clarity. > You need to compile test code before sending it. It can't be changed from being a NULL pointer now so it breaks. regards, dan carpenter