From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v1] video: fbdev: pxafb: Convert to use match_string() helper
Date: Tue, 15 May 2018 16:23:09 +0000 [thread overview]
Message-ID: <e742b940e9a980862a6a7a87b62ce37acff1855b.camel@linux.intel.com> (raw)
In-Reply-To: <20180503180423.21710-1-andriy.shevchenko@linux.intel.com>
On Tue, 2018-05-15 at 18:06 +0200, Bartlomiej Zolnierkiewicz wrote:
> On Tuesday, May 15, 2018 02:17:35 PM Bartlomiej Zolnierkiewicz wrote:
> > On Tuesday, May 15, 2018 02:59:20 PM Andy Shevchenko wrote:
> > It is already merged in publicly available tree (which is not being
> > rebased) so it is too late to drop it completely.
Oh, sorry for that.
> OK, I fixed it myself with the patch below.
>
> From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Subject: [PATCH] video: fbdev: pxafb: match_string() conversion fixup
>
> "unknown" lcd_types[] entry is needed for proper operation of
> the driver, add it back.
Yes, that's correct now.
I was thinking that we perhaps add a comment that the list of these
names should be in sync with definitions in the header.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2018-05-15 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 18:04 [PATCH v1] video: fbdev: pxafb: Convert to use match_string() helper Andy Shevchenko
2018-05-15 10:37 ` Bartlomiej Zolnierkiewicz
2018-05-15 11:35 ` Andy Shevchenko
2018-05-15 11:54 ` Bartlomiej Zolnierkiewicz
2018-05-15 11:59 ` Andy Shevchenko
2018-05-15 12:17 ` Bartlomiej Zolnierkiewicz
2018-05-15 16:06 ` Bartlomiej Zolnierkiewicz
2018-05-15 16:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e742b940e9a980862a6a7a87b62ce37acff1855b.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).