From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE18B412C1E for ; Mon, 27 Jul 2026 14:58:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785164298; cv=none; b=Jv4nX6f0QAHt/CrWMFSRToVfgdTRQ6v52yH1RvIwHhOGZDy5CUJBk7o7wtCR4JMr8Fu59MxdDEONi99UlI60S4P6H7msmUjvPBOTVA66UL3OcEE26CMcN4n+BtqIt9L2nJCf2HfJI5LCOg1jzpctSTjSc6KOo/xK6+qNneSIx68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785164298; c=relaxed/simple; bh=/pHEhqhHim6zbvXlXGSytIteuWLfY5Kr9gwBWC8fFio=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XjuW+99uEnggCvVVNP7MWOWWwnScKqboQ3ATpqsmVftljFpHEZt8WysaMgS+RT0INucsT+ZEfGvgcRiMhE9X05xbJ2fvZmYZ8/psG/GuikpmCQ/aY4Ru4O+DK6AYxUUnYyUnGf8JG8kP29Vixi7imoeM8PCQdfRYEPrnQ7oRVoo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=WtIrJspU; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="WtIrJspU" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47ddf7b09e5so2882309f8f.1 for ; Mon, 27 Jul 2026 07:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785164294; x=1785769094; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cdTAOusKdU7cIGVdiXhGRlX7Lluomu67uAna+oJrbLI=; b=WtIrJspUFDv9uYL8E4OhCURfnCutsSkbOm+juL/6yCshO8FMCiFZrYMSEpcfsdW4Nh iKdHsW3hXXVC8Pl4kUTysqT9Zr8oF1RzlXcRzFSGc2UBRbewwmpIc4cUdB8jmp3pl1An f6O93wZ1uT86BMhjp0hkFyCYKEgWqWi968vQRJXARDoAz7+tu8TEFguRFWLq/na2hZxb h+/lKgJgJ7KvEmuOlPlx1TgAEAOP3gxpUS2jY/c4WBF4cEndQhBSKAsMyUFZVAH/YqQT oXvZ+5VFrjrP5i1FIj+Vs0SajlFsW+dWgVvOzDcsFpUW8FB2tzSLDDUFkca3REdCvM53 ZAVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785164294; x=1785769094; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cdTAOusKdU7cIGVdiXhGRlX7Lluomu67uAna+oJrbLI=; b=o16fcdrg+zylfnUBNbOZcxUu8kOdnWlJlonpQZqL3WWNIPAVnGku3CydTJVL0cQlgk x9eGtF0qi1pIc9iTf9PMBwWxTFFAu8a25EFD2LEUM4UiRYf1GJyuO7g8b5a8CPk86I/8 ZQyuWEPzL1/9a57hT+3KJke57dthU2Ti+ccb2Rfcr0erVNMjt1HappHrJMrzL5MNKbzY 9FMTBtY7ahGy24y/bnS8qRvSAawH4SBo/C4zKKHKlDPfDtfIQeWFZem167f91TPtNclK 9W8Jyxj6/rys8cypTr+e+R33Dh3fPkHIrWv8yrvDIQ6PHFdg5st36C5QwIY+jqvTE9aW V/uw== X-Forwarded-Encrypted: i=1; AHgh+RpdsQl1STOkSeFC9dAuby/fgKRvvQF0nbJLN3iqvLEadlz8WJbKQ+yivy5EDOHbixH6CJFYp6hTjPUpDw==@vger.kernel.org X-Gm-Message-State: AOJu0YxtNyViCGfXay7TCkTXtbb2M1Lq2BanABIrMkTPoJPbNZSt0q13 6rl3+ZUqSGAqpAUoJ6BPrWcdbrfs2SRX+wuv02CXISG0chO5XmIdCb8HoEBTUauQQWE= X-Gm-Gg: AR+sD12fdHklfiBosdT0y1DQljKIJs76EoIjlgDM5ocB1U31jisA8INV7yTpblDa7LV U27Ahp4gOuxsS2D6ponxuUlvanOUTFpjD/CUhm6tEPsGYOMgV1zwtuIZsV6VVEU4DtaMNFPOn0z 7HqXaX9PDXn+UjoN8l31kAlO0yxWQ6Sj8hWrWCn15yLKhg8M93NRRa4bH22boy3tmAoqEW1f/oF EtaS1Vt8RhIYAqyG+Dw1L7MerkzBYLXQoWlATPHdi7yaGac2JD/9dmsyEEO00dqv6MP11Oztsqp BIsz/5NaDLiB2Y1nSq5hboMmQYGk2iIfUKodfdg1Edaz4eHakOVtyDKlcLx+/vJAe+XQuekAqZf KtJ9raZRYHQyy9iBQJWMbRObkB4bpTh2VDRWgItF5L4VbeaWgias1MNejyNNv8D25xXFuqCoSiN PdtMsOYFbJWSC78GB/xzKQyiZOzrKXUZkJSmULpYU= X-Received: by 2002:a05:600c:1553:b0:493:e97c:216e with SMTP id 5b1f17b1804b1-496b5731987mr114339235e9.39.1785164294020; Mon, 27 Jul 2026 07:58:14 -0700 (PDT) Received: from ?IPV6:2a07:de40:8100:0:fc6c:f9a2:4a0a:6354? ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-496b4ee0e91sm231594995e9.4.2026.07.27.07.58.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2026 07:58:13 -0700 (PDT) Message-ID: Date: Mon, 27 Jul 2026 16:58:11 +0200 Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] time/jiffies: Include linux/sysctl.h for proc_int_u2k_conv_uop(), ... To: Thomas Gleixner Cc: Tony Luck , Borislav Petkov , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Philipp Reisner , Lars Ellenberg , =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= , Jens Axboe , Johan Hovold , Alex Elder , Greg Kroah-Hartman , "Rafael J. Wysocki" , Michal Januszewski , Helge Deller , Alexander Viro , Christian Brauner , Jan Kara , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Mark Fasheh , Joel Becker , Joseph Qi , Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Pavel Machek , Len Brown , Andrew Morton , Danilo Krummrich , Nikolay Aleksandrov , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" , Kentaro Takeda , Tetsuo Handa , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linux.dev, linux-block@vger.kernel.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev, cgroups@vger.kernel.org, linux-modules@vger.kernel.org, linux-pm@vger.kernel.org, driver-core@lists.linux.dev, bridge@lists.linux.dev, netdev@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org References: <20260721131207.803760-1-petr.pavlu@suse.com> <20260721131207.803760-3-petr.pavlu@suse.com> <874ihmke0k.ffs@fw13> Content-Language: en-US From: Petr Pavlu In-Reply-To: <874ihmke0k.ffs@fw13> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/25/26 10:31 PM, Thomas Gleixner wrote: > On Tue, Jul 21 2026 at 15:11, Petr Pavlu wrote: > >> The kernel/time/jiffies.c file uses proc_int_u2k_conv_uop(), > > jiffies.c uses ... > >> proc_int_k2u_conv_kop(), proc_int_conv(), proc_dointvec_conv() and >> proc_doulongvec_minmax_conv(), which are declared in linux/sysctl.h. It >> currently relies on this header being included indirectly through >> linux/module.h -> linux/kmod.h. Add the missing include in preparation for >> removing the linux/sysctl.h include from linux/kmod.h. > > Can you please split that spaghetti sentence into paragraphs? > > https://docs.kernel.org/process/maintainer-tip.html#changelog I will update it to: jiffies.c uses proc_int_u2k_conv_uop(), proc_int_k2u_conv_kop(), proc_int_conv(), proc_dointvec_conv() and proc_doulongvec_minmax_conv(), which are declared in linux/sysctl.h. It currently gets that header indirectly through linux/module.h -> linux/kmod.h, but the latter no longer needs to include linux/sysctl.h. Include linux/sysctl.h directly in jiffies.c ahead of removing the unnecessary include from linux/kmod.h. > >> Signed-off-by: Petr Pavlu > > Other than that. > > Acked-by: Thomas Gleixner -- Thanks, Petr