From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D460A6A35A for ; Sun, 28 Apr 2024 14:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714313014; cv=none; b=PRhxZjyQR5wh+xge+eJPkgrvG3od0Bqq/gAdL086XuEuiy/LdXb0JKbylFSohykgz/AnbDjcmdsZxjmEoJ+FvkfwILcqBI5sn7paLYuqn0yDvEGlr9ZAJ6D/6pyDQQdSF+RdFDUZg0XUF7DjJGn+OYnteFH/QFeUh0L1kPUIpAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714313014; c=relaxed/simple; bh=W4Rekvj5rjMQEMyrvrDguiibMfMdswqmFgzCJjSBkmE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t6Mjd4Rl78UH7bs4l3/1OHisUKJvUMJnr5GoAGbdmlCrjkMktf63K4uLyf93XCynOt2FsEb8bPutGhuLQof6DFL2mLJMRzm18r6FRIgd7JwhFBM0sKpZBVHqaOf+q883jp99XSMx8DZN7Zm8mJyKfDV/pEFPsok40F9KDXmK/MI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lkRHzluf; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lkRHzluf" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5727c009fe4so625777a12.3 for ; Sun, 28 Apr 2024 07:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714313011; x=1714917811; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4LkwHkM4YstZ7I6Hr8RDgjhYJhml/L2D5NhBnPSk8m0=; b=lkRHzlufAyABx0DLN7ItkAqhki1SPKtkRhbbINRB9HUFPXIJvjB8YTXiFrcLPLXG3+ n1uqqdvsztOm61jiu/M4IblyhMfJkq4cFXVR6RDUdiQ12Brq94nx6BLn8aB9CBCpDRdn 8zTg0vIdb1ytcOrgRKrn0UXOPBgsh0rnvYIPZAFpI+FWSUubr4PcNVy4HuTy/sIN3ApG qCvtdGEsv75Sd9rAP2vit1e13jDMh8ZfRnMcnFbDPRTJ+b6BlEOZ11xbMXUokpzNbGqD eCxRBSGjVoEylqqbzqoYX3kwu0NRAGIILrIYQjxpKVpWRmlZt6RKKg7sHcD6gJyPG/lX YsXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714313011; x=1714917811; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4LkwHkM4YstZ7I6Hr8RDgjhYJhml/L2D5NhBnPSk8m0=; b=tgW2pnTjsMjco8Gs2TzfloQCou/Dzf9xjPA34ZDGr4QrZ7gRMu8wcSdFRlVE9pNyDT XwvnWotuiR3/aBPo30Rfi+adlrlI9s0DdnUSIzaiea603ZMmszOCYJSl3gEnha7+KyIQ TSA5J4XR5322+R1IhzS0/3y4FrPqWUMVe+Lh+OTYG47bLmydIG2S8pRraclYMGDV1k0p A4zIaNl4PlS1fZpvVD8QIE9DqghAckopRqxRzdazu/hKRFt52n+teeDb7lgZyUHopb5N XO80a5S/XRHtsve84uTMKb8yT5boBZVMxRYML7q/xoIMjxoFSYXOQC7zIqEQ7Z/MJiKx vt5Q== X-Forwarded-Encrypted: i=1; AJvYcCWUNQTapZXkJsKjVupmn3iALEXMs1cqd/Sm8JgL5JgVblR9H+liKTDDfoQkPias0fp7WVUHH8IC5HD/lQqJOsb30y9M1yAUlxbJPyw= X-Gm-Message-State: AOJu0YyFApwHmF0T7Nv7LI4g49tx3x9UfCXM0O0UtFmfdIdeaoMYJU5B G6ILEZeFDJQyO7WVmoBmhmxK1LENgT2FeiMrwnuJdQpJ2AoGru1C6GwUyyKdgkg= X-Google-Smtp-Source: AGHT+IEsYnfmO00nQBKypL68lPb0+Y9MZyh6Sub86JRNTqRLbUZ2ckphZO76Q5wRWKp2auF76BFgvA== X-Received: by 2002:a05:6402:26cc:b0:572:57d8:4542 with SMTP id x12-20020a05640226cc00b0057257d84542mr4475106edd.8.1714313010990; Sun, 28 Apr 2024 07:03:30 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id j2-20020aa7de82000000b005720e083878sm7545949edv.49.2024.04.28.07.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Apr 2024 07:03:30 -0700 (PDT) Date: Sun, 28 Apr 2024 17:03:27 +0300 From: Dan Carpenter To: pipishuo <1289151713@qq.com> Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft:fixes unnecessary parentheses Message-ID: References: Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Apr 28, 2024 at 08:19:08PM +0800, pipishuo wrote: > This patch fixes the checks reported by checkpatch.pl > for unnecessary parentheses > > Signed-off-by: pipishuo <1289151713@qq.com> > --- > drivers/staging/fbtft/fb_ili9320.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c > index 0be7c2d51548..045275a9bc0b 100644 > --- a/drivers/staging/fbtft/fb_ili9320.c > +++ b/drivers/staging/fbtft/fb_ili9320.c > @@ -37,7 +37,8 @@ static int init_display(struct fbtft_par *par) > devcode = read_devicecode(par); > fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code: 0x%04X\n", > devcode); > - if ((devcode != 0x0000) && (devcode != 0x9320)) > + if (devcode != 0x0000 && > + devcode != 0x9320) Nah, just leave it. It's a personal preference for Greg. https://lore.kernel.org/all/?q=init_display%20devcode regards, dan carpenter