From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] omapfb: fix return value check in dsi_bind()
Date: Tue, 20 Sep 2016 09:22:39 +0000 [thread overview]
Message-ID: <ecdac13c-a697-92dd-25d4-34646c3a3e9e@ti.com> (raw)
In-Reply-To: <1474127614-14350-1-git-send-email-weiyj.lk@gmail.com>
On 09/17/16 18:53, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the retrn value check which testing the wrong variable
> in dsi_bind().
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> index 9e4800a..951dd93 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> @@ -5348,7 +5348,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>
> dsi->phy_base = devm_ioremap(&dsidev->dev, res->start,
> resource_size(res));
> - if (!dsi->proto_base) {
> + if (!dsi->phy_base) {
> DSSERR("can't ioremap DSI PHY\n");
> return -ENOMEM;
> }
> @@ -5368,7 +5368,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>
> dsi->pll_base = devm_ioremap(&dsidev->dev, res->start,
> resource_size(res));
> - if (!dsi->proto_base) {
> + if (!dsi->pll_base) {
> DSSERR("can't ioremap DSI PLL\n");
> return -ENOMEM;
> }
>
--
Péter
next prev parent reply other threads:[~2016-09-20 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 15:53 [PATCH] omapfb: fix return value check in dsi_bind() Wei Yongjun
2016-09-20 9:22 ` Peter Ujfalusi [this message]
2016-09-27 8:04 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecdac13c-a697-92dd-25d4-34646c3a3e9e@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).