Re: [PATCH 2/6] backlight/omap1-bl: Remove unused struct omap_backlight_config.set_power

Sam Ravnborg
2024-03-13T18:03:27Z

On Wed, Mar 13, 2024 at 04:45:01PM +0100, Thomas Zimmermann wrote:
> The callback set_power in struct omap_backlight_config is not
> implemented anywhere. Remove it from the structure and driver.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/video/backlight/omap1_bl.c | 3 ---
> include/linux/platform_data/omap1_bl.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/video/backlight/omap1_bl.c b/drivers/video/backlight/omap1_bl.c
> index 69a49384b3de4..84d148f385951 100644
> --- a/drivers/video/backlight/omap1_bl.c
> +++ b/drivers/video/backlight/omap1_bl.c
> @@ -39,9 +39,6 @@ static inline void omapbl_send_enable(int enable)
>
> static void omapbl_blank(struct omap_backlight *bl, int mode)
> {
> - if (bl->pdata->set_power)
> - bl->pdata->set_power(bl->dev, mode);
> -
> switch (mode) {
> case FB_BLANK_NORMAL:
> case FB_BLANK_VSYNC_SUSPEND:
> diff --git a/include/linux/platform_data/omap1_bl.h b/include/linux/platform_data/omap1_bl.h
> index 5e8b17d77a5fe..3d0bab31a0a94 100644
> --- a/include/linux/platform_data/omap1_bl.h
> +++ b/include/linux/platform_data/omap1_bl.h
> @@ -6,7 +6,6 @@
>
> struct omap_backlight_config {
> int default_intensity;
> - int (*set_power)(struct device *dev, int state);
> };
>
> #endif
> --
> 2.44.0