From: Thomas Huth <thuth@redhat.com>
To: Farhan Ali <alifm@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-fbdev@vger.kernel.org
Cc: schwidefsky@de.ibm.com, borntraeger@de.ibm.com,
stefan.kristiansson@saunalahti.fi, tomi.valkeinen@ti.com
Subject: Re: [PATCH v1 1/2] Kconfig : Remove HAS_IOMEM dependency for Graphics support
Date: Fri, 26 Jan 2018 12:31:22 +0000 [thread overview]
Message-ID: <ee02c1b7-09f3-34b1-2bd0-1d608d6a5faf@redhat.com> (raw)
In-Reply-To: <a4d2db8f1f9e1b8fa36815eb6a562224f9ab2ca2.1516892845.git.alifm@linux.vnet.ibm.com>
On 25.01.2018 16:47, Farhan Ali wrote:
> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")'
> added the HAS_IOMEM dependecy for "Graphics support". This disabled the
> "Graphics support" menu for S390. But if we enable VT layer for S390,
> we would also need to enable the dummy console. So let's remove the
> HAS_IOMEM dependency.
>
> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
> Tested-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
> ---
> drivers/video/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 3c20af9..41e7ba9 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -3,7 +3,6 @@
> #
>
> menu "Graphics support"
> - depends on HAS_IOMEM
Generally a good idea, but should the removed line maybe rather be added
to the menu "Frame buffer Devices" now instead?
Thomas
next prev parent reply other threads:[~2018-01-26 12:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 15:47 [PATCH v1 0/2] Kconfig changes to enable Graphics Support for S390 Farhan Ali
2018-01-25 15:47 ` [PATCH v1 1/2] Kconfig : Remove HAS_IOMEM dependency for Graphics support Farhan Ali
2018-01-26 12:31 ` Thomas Huth [this message]
2018-01-25 15:47 ` [PATCH v1 2/2] fbdev: Kconfig: Add HAS_IOMEM dependency for FB_OPENCORES Farhan Ali
2018-01-26 12:33 ` Thomas Huth
2018-01-26 12:38 ` Tomi Valkeinen
2018-01-26 14:32 ` Farhan Ali
2018-01-26 13:41 ` [PATCH v1 0/2] Kconfig changes to enable Graphics Support for S390 Geert Uytterhoeven
2018-01-26 14:35 ` Farhan Ali
2018-01-26 15:06 ` Geert Uytterhoeven
2018-01-26 16:26 ` Farhan Ali
2018-01-30 13:22 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee02c1b7-09f3-34b1-2bd0-1d608d6a5faf@redhat.com \
--to=thuth@redhat.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).