From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Date: Fri, 26 Jan 2018 12:31:22 +0000 Subject: Re: [PATCH v1 1/2] Kconfig : Remove HAS_IOMEM dependency for Graphics support Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Farhan Ali , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: schwidefsky@de.ibm.com, borntraeger@de.ibm.com, stefan.kristiansson@saunalahti.fi, tomi.valkeinen@ti.com On 25.01.2018 16:47, Farhan Ali wrote: > The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' > added the HAS_IOMEM dependecy for "Graphics support". This disabled the > "Graphics support" menu for S390. But if we enable VT layer for S390, > we would also need to enable the dummy console. So let's remove the > HAS_IOMEM dependency. > > Signed-off-by: Farhan Ali > Tested-by: Dong Jia Shi > --- > drivers/video/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 3c20af9..41e7ba9 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -3,7 +3,6 @@ > # > > menu "Graphics support" > - depends on HAS_IOMEM Generally a good idea, but should the removed line maybe rather be added to the menu "Frame buffer Devices" now instead? Thomas