From: Hans de Goede <hdegoede@redhat.com>
To: Rob Herring <robh+dt@kernel.org>, Rayyan Ansari <rayyan@ansari.sh>
Cc: dri-devel@lists.freedesktop.org,
~postmarketos/upstreaming@lists.sr.ht, asahi@lists.linux.dev,
janne@jannau.net, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@gmail.com>,
devicetree@vger.kernel.org,
Javier Martinez Canillas <javierm@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH v2 2/2] dt-bindings: display: simple-framebuffer: Document physical width and height properties
Date: Sun, 22 Jan 2023 16:42:22 +0100 [thread overview]
Message-ID: <efcca646-5dc3-359a-5453-2fe241af8f8c@redhat.com> (raw)
In-Reply-To: <CAL_JsqL+G=Cxkc2j_NowznpqNAnixrU+-6SdccFbpMaP6OYSqQ@mail.gmail.com>
Hi,
On 1/22/23 16:36, Rob Herring wrote:
> On Sat, Jan 21, 2023 at 9:36 AM Rayyan Ansari <rayyan@ansari.sh> wrote:
>>
>
> Why do you need this change?
>
> The 'simple-framebuffer' contains data on how the bootloader
> configured the display. The bootloader doesn't configure the display
> size, so this information doesn't belong here. The information should
> already be in the panel node, so also no point in duplicating it here.
The idea is that early boot code which uses the simplefb node (no more
complex display driver loaded yet) knows the panel's DPI so that it can
decide if hi-dpi rendering / scaling is necessary or not.
This definitely is a useful feature to have.
I guess that for dt systems an alternative approach could be to
add a link to the panel node to the simplefb dt-node.
Regards,
Hans
next prev parent reply other threads:[~2023-01-22 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 15:35 [PATCH v2 0/2] SimpleDRM: allow configuring physical width and height Rayyan Ansari
2023-01-21 15:35 ` [PATCH v2 1/2] drm/simpledrm: Allow physical width and height configuration via DT Rayyan Ansari
2023-01-26 13:05 ` Thomas Zimmermann
2023-01-21 15:35 ` [PATCH v2 2/2] dt-bindings: display: simple-framebuffer: Document physical width and height properties Rayyan Ansari
2023-01-22 15:31 ` Rob Herring
2023-01-22 17:28 ` Rayyan Ansari
2023-01-22 15:36 ` Rob Herring
2023-01-22 15:42 ` Hans de Goede [this message]
2023-01-22 17:25 ` Rayyan Ansari
2023-01-23 17:53 ` Rob Herring
2023-01-24 22:19 ` Rayyan Ansari
2023-01-24 22:40 ` Mark Kettenis
2023-01-25 7:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efcca646-5dc3-359a-5453-2fe241af8f8c@redhat.com \
--to=hdegoede@redhat.com \
--cc=airlied@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=janne@jannau.net \
--cc=javierm@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rayyan@ansari.sh \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).