Re: [RFC 2.6.26-rc9 4/5] metronomefb: convert printk to dev_dbg/err messages

["eric miao" <eric.y.miao@gmail.com>]

On Sun, Jul 13, 2008 at 9:26 PM, Jaya Kumar <jayakumar.lkml@gmail.com> wrote:
> This patch converts the printk messages in metronomefb to dev_dbg/err type
> messages.
>

This is always a good thing to do :)

> Signed-off-by: Jaya Kumar <jayakumar.lkml@gmail.com>

With the removal of "#define DEBUG 1",

Acked-by: Eric Miao <eric.miao@marvell.com>

> ---
>  drivers/video/metronomefb.c |   49 +++++++++++++++++++-----------------------
>  1 files changed, 22 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c
> index cc4c038..8ccd113 100644
> --- a/drivers/video/metronomefb.c
> +++ b/drivers/video/metronomefb.c
> @@ -18,6 +18,8 @@
>  * is provided as am200epd.c
>  *
>  */
> +#define DEBUG 1
> +

Don't leave DEBUG in the final patch please.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/