From: "Eric Miao" <eric.y.miao@gmail.com>
To: Stefan Schmidt <stefan@datenfreihafen.org>
Cc: ARM Linux <linux-arm-kernel@lists.arm.linux.org.uk>,
linux-fbdev-devel@lists.sourceforge.net,
Jaya Kumar <jayakumar.lkml@gmail.com>,
Mike Rapoport <mike@compulab.co.il>,
Richard Purdie <rpurdie@rpsys.net>, Ian Molton <spyro@f2s.com>,
pHilipp Zabel <philipp.zabel@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Marc Zyngier <maz@misterjones.org>,
Juergen Schindele <linux@schindele.name>
Subject: Re: [PATCH 1/2] pxa: introduce GPIOxx_LCD_* macros for easier pin configuration
Date: Fri, 12 Dec 2008 10:41:43 +0800 [thread overview]
Message-ID: <f17812d70812111841o5d2fc957se524ad0dd652f45b@mail.gmail.com> (raw)
In-Reply-To: <20081211163912.GB4407@excalibur.local>
On Fri, Dec 12, 2008 at 12:39 AM, Stefan Schmidt
<stefan@datenfreihafen.org> wrote:
> Hello.
>
> On Thu, 2008-12-11 at 17:04, Eric Miao wrote:
>> From ed2c9a22a9653880fad7e22333c7d6155c45c399 Mon Sep 17 00:00:00 2001
>> From: Eric Miao <eric.miao@marvell.com>
>> Date: Thu, 11 Dec 2008 13:34:54 +0800
>> Subject: [PATCH] [ARM] pxa: introduce GPIOxx_LCD_* macros for easier
>> pin configuration
>>
>> For those peripherals with only one possible pin configuration, introduce
>> handy macros of GPIOxx_*, it also avoids potential copy-and-paste errors.
>>
>> Let's start from LCD for PXA25x/PXA27x, depending on the different mode
>> used: passive (STN), active (TFT) and LCD with internal framebuffer (i.e.
>> smart panel), and the actual number of pins used to connect to the LCD
>> panel, the configurations slightly differ.
>>
>> Also, let's fix the issue of LCD pin configurations are missed from some
>> platforms (e.g. am200epd, cm-x270, e400)
>>
>> NOTE: the 18bpp and smart panel are only available on PXA27x.
>
> [SNIP]
>
>> diff --git a/arch/arm/mach-pxa/ezx.c b/arch/arm/mach-pxa/ezx.c
>> index 4f212e1..051fc49 100644
>> --- a/arch/arm/mach-pxa/ezx.c
>> +++ b/arch/arm/mach-pxa/ezx.c
>> @@ -147,6 +147,9 @@ static unsigned long gen1_pin_config[] __initdata = {
>> /* flip / lockswitch */
>> GPIO12_GPIO,
>>
>> + /* LCD */
>> + GPIOxx_LCD_TFT_16BPP,
>> +
>> /* bluetooth (bcm2035) */
>> GPIO14_GPIO | WAKEUP_ON_LEVEL_HIGH, /* HOSTWAKE */
>> GPIO48_GPIO, /* RESET */
>> @@ -205,6 +208,9 @@ static unsigned long gen2_pin_config[] __initdata = {
>> /* EOC */
>> GPIO10_GPIO,
>>
>> + /* LCD */
>> + GPIOxx_LCD_TFT_18BPP,
>> +
>> /* bluetooth (bcm2045) */
>> GPIO13_GPIO | WAKEUP_ON_LEVEL_HIGH, /* HOSTWAKE */
>> GPIO37_GPIO, /* RESET */
>
> The ezx.c part looks fine to me. If you like you could put my ACK in, but I
> don't think you need it being a pxa maintainer.
>
Just the opposite, I need your Ack to make sure I'm not breaking anything
that I don't have a chance to test. So this is really appreciated instead.
-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
next prev parent reply other threads:[~2008-12-12 2:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 9:04 [PATCH 1/2] pxa: introduce GPIOxx_LCD_* macros for easier pin configuration Eric Miao
2008-12-11 16:39 ` Stefan Schmidt
2008-12-12 2:41 ` Eric Miao [this message]
2008-12-11 18:43 ` Marc Zyngier
2008-12-14 6:54 ` Mike Rapoport
2008-12-14 16:22 ` Jaya Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70812111841o5d2fc957se524ad0dd652f45b@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=jayakumar.lkml@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux@schindele.name \
--cc=marek.vasut@gmail.com \
--cc=maz@misterjones.org \
--cc=mike@compulab.co.il \
--cc=philipp.zabel@gmail.com \
--cc=rpurdie@rpsys.net \
--cc=spyro@f2s.com \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).