Re: [PATCH 7/8] pxa: add frame buffer on pxa168 aspenite platform

[Eric Miao <eric.y.miao@gmail.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1253", Size: 947 bytes --]

> +       int err = 0;
> +       if (on) {
> +               if (spi_gpio_reset != -1) {
> +                       err = gpio_request(spi_gpio_reset, "TPO_LCD_SPI_RESET");
> +                       if (err) {
> +                               printk(KERN_ERR "failed to request GPIO for TPO LCD RESET\n");
> +                               return err;
> +                       }
> +                       gpio_direction_output(spi_gpio_reset, 0);
> +                       msleep(100);

This is really a loooong delay, there any specific reason for such a long
delay, I'm seeing this to slow down the boot up significantly?

Otherwise looks OK to me, and I prefer the defconfig file change to
be a separate patch please.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±ýöÝzÿâžØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm