* [PATCH 1/3] video: fbdev: Add additional vesa modes
@ 2014-12-03 21:49 David Ung
2014-12-04 14:53 ` Tomi Valkeinen
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: David Ung @ 2014-12-03 21:49 UTC (permalink / raw)
To: linux-fbdev
Add high resolution modes to vesa_modes struct.
Signed-off-by: David Ung <davidu@nvidia.com>
---
drivers/video/fbdev/core/modedb.c | 27 +++++++++++++++++++++++++++
include/linux/fb.h | 2 +-
2 files changed, 28 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/core/modedb.c b/drivers/video/fbdev/core/modedb.c
index 388f797..0b57c1df 100644
--- a/drivers/video/fbdev/core/modedb.c
+++ b/drivers/video/fbdev/core/modedb.c
@@ -468,6 +468,33 @@ const struct fb_videomode vesa_modes[] = {
/* 33 1920x1440-75 VESA */
{ NULL, 75, 1920, 1440, 3367, 352, 144, 56, 1, 224, 3,
FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
+ /* 34 1920x1200-60 RB VESA */
+ { NULL, 60, 1920, 1200, 6493, 80, 48, 26, 3, 32, 6,
+ FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
+ /* 35 1920x1200-60 VESA */
+ { NULL, 60, 1920, 1200, 5174, 336, 136, 36, 3, 200, 6,
+ FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
+ /* 36 1920x1200-75 VESA */
+ { NULL, 75, 1920, 1200, 4077, 344, 136, 46, 3, 208, 6,
+ FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
+ /* 37 1920x1200-85 VESA */
+ { NULL, 85, 1920, 1200, 3555, 352, 144, 53, 3, 208, 6,
+ FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
+ /* 38 2560x1600-60 RB VESA */
+ { NULL, 60, 2560, 1600, 3724, 80, 48, 37, 3, 32, 6,
+ FB_SYNC_HOR_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
+ /* 39 2560x1600-60 VESA */
+ { NULL, 60, 2560, 1600, 2869, 472, 192, 49, 3, 280, 6,
+ FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
+ /* 40 2560x1600-75 VESA */
+ { NULL, 75, 2560, 1600, 2256, 488, 208, 63, 3, 280, 6,
+ FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
+ /* 41 2560x1600-85 VESA */
+ { NULL, 85, 2560, 1600, 1979, 488, 208, 73, 3, 280, 6,
+ FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
+ /* 42 2560x1600-120 RB VESA */
+ { NULL, 120, 2560, 1600, 1809, 80, 48, 85, 3, 32, 6,
+ FB_SYNC_HOR_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
};
EXPORT_SYMBOL(vesa_modes);
#endif /* CONFIG_FB_MODE_HELPERS */
diff --git a/include/linux/fb.h b/include/linux/fb.h
index 09bb7a1..882dbd1 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -726,7 +726,7 @@ extern int fb_videomode_from_videomode(const struct videomode *vm,
struct fb_videomode *fbmode);
/* drivers/video/modedb.c */
-#define VESA_MODEDB_SIZE 34
+#define VESA_MODEDB_SIZE 43
extern void fb_var_to_videomode(struct fb_videomode *mode,
const struct fb_var_screeninfo *var);
extern void fb_videomode_to_var(struct fb_var_screeninfo *var,
--
1.8.1.5
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] video: fbdev: Add additional vesa modes
2014-12-03 21:49 [PATCH 1/3] video: fbdev: Add additional vesa modes David Ung
@ 2014-12-04 14:53 ` Tomi Valkeinen
2014-12-05 3:54 ` David Ung
2015-01-13 7:32 ` David Ung
2 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2014-12-04 14:53 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 2391 bytes --]
On 03/12/14 23:49, David Ung wrote:
> Add high resolution modes to vesa_modes struct.
>
> Signed-off-by: David Ung <davidu@nvidia.com>
> ---
> drivers/video/fbdev/core/modedb.c | 27 +++++++++++++++++++++++++++
> include/linux/fb.h | 2 +-
> 2 files changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/core/modedb.c b/drivers/video/fbdev/core/modedb.c
> index 388f797..0b57c1df 100644
> --- a/drivers/video/fbdev/core/modedb.c
> +++ b/drivers/video/fbdev/core/modedb.c
> @@ -468,6 +468,33 @@ const struct fb_videomode vesa_modes[] = {
> /* 33 1920x1440-75 VESA */
> { NULL, 75, 1920, 1440, 3367, 352, 144, 56, 1, 224, 3,
> FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
> + /* 34 1920x1200-60 RB VESA */
> + { NULL, 60, 1920, 1200, 6493, 80, 48, 26, 3, 32, 6,
> + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
> + /* 35 1920x1200-60 VESA */
> + { NULL, 60, 1920, 1200, 5174, 336, 136, 36, 3, 200, 6,
> + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
> + /* 36 1920x1200-75 VESA */
> + { NULL, 75, 1920, 1200, 4077, 344, 136, 46, 3, 208, 6,
> + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
> + /* 37 1920x1200-85 VESA */
> + { NULL, 85, 1920, 1200, 3555, 352, 144, 53, 3, 208, 6,
> + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
> + /* 38 2560x1600-60 RB VESA */
> + { NULL, 60, 2560, 1600, 3724, 80, 48, 37, 3, 32, 6,
> + FB_SYNC_HOR_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
> + /* 39 2560x1600-60 VESA */
> + { NULL, 60, 2560, 1600, 2869, 472, 192, 49, 3, 280, 6,
> + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
> + /* 40 2560x1600-75 VESA */
> + { NULL, 75, 2560, 1600, 2256, 488, 208, 63, 3, 280, 6,
> + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
> + /* 41 2560x1600-85 VESA */
> + { NULL, 85, 2560, 1600, 1979, 488, 208, 73, 3, 280, 6,
> + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
> + /* 42 2560x1600-120 RB VESA */
> + { NULL, 120, 2560, 1600, 1809, 80, 48, 85, 3, 32, 6,
> + FB_SYNC_HOR_HIGH_ACT, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA },
Where did you take these timings? Are the modes in vesa_modes[] in some
defined order, or just in the order they have been added?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/3] video: fbdev: Add additional vesa modes
2014-12-03 21:49 [PATCH 1/3] video: fbdev: Add additional vesa modes David Ung
2014-12-04 14:53 ` Tomi Valkeinen
@ 2014-12-05 3:54 ` David Ung
2015-01-13 7:32 ` David Ung
2 siblings, 0 replies; 4+ messages in thread
From: David Ung @ 2014-12-05 3:54 UTC (permalink / raw)
To: linux-fbdev
> On 03/12/14 23:49, David Ung wrote:
> > Add high resolution modes to vesa_modes struct.
> >
> > Signed-off-by: David Ung <davidu@nvidia.com>
> > ---
> > drivers/video/fbdev/core/modedb.c | 27 +++++++++++++++++++++++++++
> > include/linux/fb.h | 2 +-
> > 2 files changed, 28 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/fbdev/core/modedb.c
> > b/drivers/video/fbdev/core/modedb.c
> > index 388f797..0b57c1df 100644
> > --- a/drivers/video/fbdev/core/modedb.c
> > +++ b/drivers/video/fbdev/core/modedb.c
> > @@ -468,6 +468,33 @@ const struct fb_videomode vesa_modes[] = {
> > /* 33 1920x1440-75 VESA */
> > { NULL, 75, 1920, 1440, 3367, 352, 144, 56, 1, 224, 3,
> > FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED,
> FB_MODE_IS_VESA },
> > + /* 34 1920x1200-60 RB VESA */
> > + { NULL, 60, 1920, 1200, 6493, 80, 48, 26, 3, 32, 6,
> > + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED,
> FB_MODE_IS_VESA },
> > + /* 35 1920x1200-60 VESA */
> > + { NULL, 60, 1920, 1200, 5174, 336, 136, 36, 3, 200, 6,
> > + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED,
> FB_MODE_IS_VESA },
> > + /* 36 1920x1200-75 VESA */
> > + { NULL, 75, 1920, 1200, 4077, 344, 136, 46, 3, 208, 6,
> > + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED,
> FB_MODE_IS_VESA },
> > + /* 37 1920x1200-85 VESA */
> > + { NULL, 85, 1920, 1200, 3555, 352, 144, 53, 3, 208, 6,
> > + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED,
> FB_MODE_IS_VESA },
> > + /* 38 2560x1600-60 RB VESA */
> > + { NULL, 60, 2560, 1600, 3724, 80, 48, 37, 3, 32, 6,
> > + FB_SYNC_HOR_HIGH_ACT, FB_VMODE_NONINTERLACED,
> FB_MODE_IS_VESA },
> > + /* 39 2560x1600-60 VESA */
> > + { NULL, 60, 2560, 1600, 2869, 472, 192, 49, 3, 280, 6,
> > + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED,
> FB_MODE_IS_VESA },
> > + /* 40 2560x1600-75 VESA */
> > + { NULL, 75, 2560, 1600, 2256, 488, 208, 63, 3, 280, 6,
> > + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED,
> FB_MODE_IS_VESA },
> > + /* 41 2560x1600-85 VESA */
> > + { NULL, 85, 2560, 1600, 1979, 488, 208, 73, 3, 280, 6,
> > + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED,
> FB_MODE_IS_VESA },
> > + /* 42 2560x1600-120 RB VESA */
> > + { NULL, 120, 2560, 1600, 1809, 80, 48, 85, 3, 32, 6,
> > + FB_SYNC_HOR_HIGH_ACT, FB_VMODE_NONINTERLACED,
> FB_MODE_IS_VESA },
>
> Where did you take these timings? Are the modes in vesa_modes[] in some
> defined order, or just in the order they have been added?
From the DMT doc. In the doc, the VESA modes are ordered by the DMT ids per page.
Each DMT mode is a valid vesa_mode. vesa_modes are just a collection of modes
people had added over time. There are quite a few modes that's missing from
vesa_modes list. Ideally the number of vesa_modes should match the number of
DMT ids. If we wish to change the ordering, then some of the other drivers which
hardcodes the an index into vesa_modes will all need to be fixed.
David
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/3] video: fbdev: Add additional vesa modes
2014-12-03 21:49 [PATCH 1/3] video: fbdev: Add additional vesa modes David Ung
2014-12-04 14:53 ` Tomi Valkeinen
2014-12-05 3:54 ` David Ung
@ 2015-01-13 7:32 ` David Ung
2 siblings, 0 replies; 4+ messages in thread
From: David Ung @ 2015-01-13 7:32 UTC (permalink / raw)
To: linux-fbdev
Any more comments with this patch?
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-13 7:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-03 21:49 [PATCH 1/3] video: fbdev: Add additional vesa modes David Ung
2014-12-04 14:53 ` Tomi Valkeinen
2014-12-05 3:54 ` David Ung
2015-01-13 7:32 ` David Ung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).