From: Hans de Goede <hdegoede@redhat.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h
Date: Fri, 14 Feb 2020 15:21:57 +0000 [thread overview]
Message-ID: <f33a4921-2b73-66c1-3165-b2e23c9fb2a8@redhat.com> (raw)
In-Reply-To: <20200204162114.28937-1-andriy.shevchenko@linux.intel.com>
Hi,
On 2/14/20 3:25 PM, Andy Shevchenko wrote:
> On Tue, Feb 04, 2020 at 06:21:14PM +0200, Andy Shevchenko wrote:
>> Replace with appropriate types.h.
>
> Hans, any comment on this?
Not really, I've not touched that code in a while.
But I see I'm still listed as the maintainer, the change looks sensible
to me, so:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> include/linux/platform_data/simplefb.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h
>> index 4f733a411d18..ca8337695c2a 100644
>> --- a/include/linux/platform_data/simplefb.h
>> +++ b/include/linux/platform_data/simplefb.h
>> @@ -10,7 +10,7 @@
>>
>> #include <drm/drm_fourcc.h>
>> #include <linux/fb.h>
>> -#include <linux/kernel.h>
>> +#include <linux/types.h>
>>
>> /* format array, use it to initialize a "struct simplefb_format" array */
>> #define SIMPLEFB_FORMATS \
>> --
>> 2.24.1
>>
>
next prev parent reply other threads:[~2020-02-14 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 16:21 [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h Andy Shevchenko
2020-02-14 14:25 ` Andy Shevchenko
2020-02-14 15:21 ` Hans de Goede [this message]
2020-02-14 18:08 ` Andy Shevchenko
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f33a4921-2b73-66c1-3165-b2e23c9fb2a8@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).