linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Javier Martinez Canillas" <javierm@redhat.com>,
	linux-kernel@vger.kernel.org
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Daniel Vetter" <daniel@ffwll.ch>, "Helge Deller" <deller@gmx.de>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v5 2/4] fbdev: Move core fbdev symbols to a separate Kconfig file
Date: Tue, 18 Jul 2023 21:36:30 +0200	[thread overview]
Message-ID: <f925fa1c-a6db-4032-8adc-d6aba8cd2ef8@app.fastmail.com> (raw)
In-Reply-To: <20230714171642.91185-3-javierm@redhat.com>

On Fri, Jul 14, 2023, at 19:16, Javier Martinez Canillas wrote:
> The drivers/video/fbdev/Kconfig defines both symbols for fbdev drivers and
> core fbdev symbols, that can be enabled independently of the fbdev drivers.
>
> Split the Kconfig in two, one that only has the symbols for fbdev drivers
> and another one that contains the fbdev core symbols.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---

While testing this patch series, I noticed a conflict against
Thomas Zimmermann's series for FB_SYS_HELPERS_DEFERRED, so you'll
have to adapt the patches in order to apply them on top.

> +
> +config FB_HECUBA
> +	tristate
> +	depends on FB
> +	depends on FB_DEFERRED_IO
> +
> +config FB_SVGALIB
> +	tristate
> +	depends on FB
> +	help
> +	  Common utility functions useful to fbdev drivers of VGA-based
> +	  cards.
> +
> +config FB_MACMODES
> +	tristate
> +	depends on FB
> +

The FB_HECUBA now needs 'FB_SYS_HELPERS_DEFERRED' instead
of 'FB_DEFERRED_IO', which is the change done in the other
patch. I think the best way of doing that would be to just
not move the three symbols above to core/Kconfig but leave them
in place, as they are all just helper modules for some other
drivers, rather than core code.

      Arnd

  reply	other threads:[~2023-07-18 19:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14 17:16 [PATCH v5 0/4] Allow disabling all native fbdev drivers and only keeping DRM emulation Javier Martinez Canillas
2023-07-14 17:16 ` [PATCH v5 1/4] video: Add auxiliary display drivers to Graphics support menu Javier Martinez Canillas
2023-07-14 17:16 ` [PATCH v5 2/4] fbdev: Move core fbdev symbols to a separate Kconfig file Javier Martinez Canillas
2023-07-18 19:36   ` Arnd Bergmann [this message]
2023-07-19  7:59     ` Javier Martinez Canillas
2023-07-14 17:16 ` [PATCH v5 3/4] fbdev: Split frame buffer support in FB and FB_CORE symbols Javier Martinez Canillas
2023-07-18 19:27   ` Arnd Bergmann
2023-07-19  7:57     ` Javier Martinez Canillas
2023-07-18 19:37 ` [PATCH v5 0/4] Allow disabling all native fbdev drivers and only keeping DRM emulation Arnd Bergmann
2023-07-19  8:00   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f925fa1c-a6db-4032-8adc-d6aba8cd2ef8@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=daniel@ffwll.ch \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=javierm@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).