* [PATCH][next] video: fbdev: kyro: make some const read-only arrays static
@ 2023-07-12 14:57 Colin Ian King
2023-07-12 15:41 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2023-07-12 14:57 UTC (permalink / raw)
To: Helge Deller, linux-fbdev, dri-devel; +Cc: kernel-janitors, linux-kernel
Don't populate the const read-only arrays on the stack but instead
make them static const. Also makes the object code a little smaller.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/video/fbdev/kyro/STG4000InitDevice.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/fbdev/kyro/STG4000InitDevice.c b/drivers/video/fbdev/kyro/STG4000InitDevice.c
index edfa0a04854d..bf1ee3addbd0 100644
--- a/drivers/video/fbdev/kyro/STG4000InitDevice.c
+++ b/drivers/video/fbdev/kyro/STG4000InitDevice.c
@@ -83,11 +83,11 @@ volatile u32 i,count=0; \
static u32 InitSDRAMRegisters(volatile STG4000REG __iomem *pSTGReg,
u32 dwSubSysID, u32 dwRevID)
{
- u32 adwSDRAMArgCfg0[] = { 0xa0, 0x80, 0xa0, 0xa0, 0xa0 };
- u32 adwSDRAMCfg1[] = { 0x8732, 0x8732, 0xa732, 0xa732, 0x8732 };
- u32 adwSDRAMCfg2[] = { 0x87d2, 0x87d2, 0xa7d2, 0x87d2, 0xa7d2 };
- u32 adwSDRAMRsh[] = { 36, 39, 40 };
- u32 adwChipSpeed[] = { 110, 120, 125 };
+ static const u32 adwSDRAMArgCfg0[] = { 0xa0, 0x80, 0xa0, 0xa0, 0xa0 };
+ static const u32 adwSDRAMCfg1[] = { 0x8732, 0x8732, 0xa732, 0xa732, 0x8732 };
+ static const u32 adwSDRAMCfg2[] = { 0x87d2, 0x87d2, 0xa7d2, 0x87d2, 0xa7d2 };
+ static const u32 adwSDRAMRsh[] = { 36, 39, 40 };
+ static const u32 adwChipSpeed[] = { 110, 120, 125 };
u32 dwMemTypeIdx;
u32 dwChipSpeedIdx;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH][next] video: fbdev: kyro: make some const read-only arrays static
2023-07-12 14:57 [PATCH][next] video: fbdev: kyro: make some const read-only arrays static Colin Ian King
@ 2023-07-12 15:41 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2023-07-12 15:41 UTC (permalink / raw)
To: Colin Ian King, linux-fbdev, dri-devel; +Cc: kernel-janitors, linux-kernel
On 7/12/23 16:57, Colin Ian King wrote:
> Don't populate the const read-only arrays on the stack but instead
> make them static const. Also makes the object code a little smaller.
Looks good, but you can optimze even further...
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/video/fbdev/kyro/STG4000InitDevice.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/kyro/STG4000InitDevice.c b/drivers/video/fbdev/kyro/STG4000InitDevice.c
> index edfa0a04854d..bf1ee3addbd0 100644
> --- a/drivers/video/fbdev/kyro/STG4000InitDevice.c
> +++ b/drivers/video/fbdev/kyro/STG4000InitDevice.c
> @@ -83,11 +83,11 @@ volatile u32 i,count=0; \
> static u32 InitSDRAMRegisters(volatile STG4000REG __iomem *pSTGReg,
> u32 dwSubSysID, u32 dwRevID)
> {
> - u32 adwSDRAMArgCfg0[] = { 0xa0, 0x80, 0xa0, 0xa0, 0xa0 };
> - u32 adwSDRAMCfg1[] = { 0x8732, 0x8732, 0xa732, 0xa732, 0x8732 };
> - u32 adwSDRAMCfg2[] = { 0x87d2, 0x87d2, 0xa7d2, 0x87d2, 0xa7d2 };
> - u32 adwSDRAMRsh[] = { 36, 39, 40 };
> - u32 adwChipSpeed[] = { 110, 120, 125 };> + static const u32 adwSDRAMArgCfg0[] = { 0xa0, 0x80, 0xa0, 0xa0, 0xa0 };
Make this u8 instead of u32 (saves 5*3 = 15 bytes):
+ static const u8 adwSDRAMArgCfg0[] = { 0xa0, 0x80, 0xa0, 0xa0, 0xa0 };
> + static const u32 adwSDRAMCfg1[] = { 0x8732, 0x8732, 0xa732, 0xa732, 0x8732 };
u16
> + static const u32 adwSDRAMCfg2[] = { 0x87d2, 0x87d2, 0xa7d2, 0x87d2, 0xa7d2 };
u16
> + static const u32 adwSDRAMRsh[] = { 36, 39, 40 };
u8
> + static const u32 adwChipSpeed[] = { 110, 120, 125 };
u8...
Can you change that (test compile) and resend?
Helge
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-12 15:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-12 14:57 [PATCH][next] video: fbdev: kyro: make some const read-only arrays static Colin Ian King
2023-07-12 15:41 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).