From: Maud Spierings <maudspierings@gocontroll.com>
To: Daniel Thompson <daniel@riscstar.com>
Cc: Lee Jones <lee@kernel.org>, Daniel Thompson <danielt@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Helge Deller <deller@gmx.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/4] backlight: add max25014atg backlight
Date: Fri, 9 Jan 2026 09:55:18 +0100 [thread overview]
Message-ID: <fc5aad54-08fe-453e-a3cf-621414c8a060@gocontroll.com> (raw)
In-Reply-To: <aTaqCxsGj_waN92Y@aspen.lan>
Do you have any comments about:
> +static void max25014_remove(struct i2c_client *cl)
> +{
> + struct max25014 *maxim = i2c_get_clientdata(cl);
> +
> + maxim->bl->props.brightness = 0;
> + max25014_update_status(maxim->bl);
> + gpiod_set_value_cansleep(maxim->enable, 0);
> + regulator_disable(maxim->vin);
> +}
I'm feeling like the setting of the brightness + update status maybe
should be a call to backlight_device_set_brightness() or maybe it
shouldn't really be there at all?
Kind regards,
Maud
next prev parent reply other threads:[~2026-01-09 8:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 11:53 [PATCH v6 0/4] backlight: add new max25014 backlight driver Maud Spierings via B4 Relay
2025-12-01 11:53 ` [PATCH v6 1/4] dt-bindings: backlight: Add max25014 support Maud Spierings via B4 Relay
2025-12-01 16:52 ` Frank Li
2025-12-02 7:46 ` Maud Spierings
2025-12-02 14:53 ` Frank Li
2025-12-08 13:56 ` Maud Spierings
2025-12-09 19:07 ` Rob Herring
2025-12-16 8:19 ` Maud Spierings
2025-12-05 15:07 ` Rob Herring
2025-12-05 15:12 ` Maud Spierings
2025-12-01 11:53 ` [PATCH v6 2/4] backlight: add max25014atg backlight Maud Spierings via B4 Relay
2025-12-04 16:17 ` Daniel Thompson
2025-12-05 15:20 ` Maud Spierings
2025-12-08 10:35 ` Daniel Thompson
2026-01-09 8:55 ` Maud Spierings [this message]
2026-01-14 16:29 ` Daniel Thompson
2025-12-01 11:53 ` [PATCH v6 3/4] arm64: dts: freescale: moduline-display-av101hdt-a10: add backlight Maud Spierings via B4 Relay
2025-12-01 11:53 ` [PATCH v6 4/4] arm64: dts: freescale: moduline-display-av123z7m-n17: " Maud Spierings via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc5aad54-08fe-453e-a3cf-621414c8a060@gocontroll.com \
--to=maudspierings@gocontroll.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@riscstar.com \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox