From: Javier Martinez Canillas <javierm@redhat.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
"open list:EFIFB FRAMEBUFFER DRIVER"
<linux-fbdev@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] Revert "drm/amdgpu: disable runpm if we are the primary adapter"
Date: Wed, 4 May 2022 19:02:07 +0200 [thread overview]
Message-ID: <fd36a5ec-e795-8b60-3a02-b865ef897da2@redhat.com> (raw)
In-Reply-To: <CADnq5_Mp7EnBUgXaT=-5ndWMW9svpsDbTypj+DdehOXsEAw_4w@mail.gmail.com>
On 5/4/22 18:50, Alex Deucher wrote:
> On Wed, May 4, 2022 at 12:46 PM Javier Martinez Canillas
> <javierm@redhat.com> wrote:
>>
>> Hello Alex,
>>
>> On 5/4/22 15:48, Alex Deucher wrote:
>>> This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b.
>>>
>>> This workaround is no longer necessary. We have a better workaround
>>> in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are displays attached (v3)").
>>>
>>
>> I would write this line instead as:
>>
>> in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are
>> displays attached (v3)").
>
> When you do it that way checkpatch and some maintainers complain about
> splitting up a commit line across multiple lines.
>
It does indeed, how silly. Scratch my comment then.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-05-04 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 13:48 [PATCH 1/2] Revert "drm/amdgpu: disable runpm if we are the primary adapter" Alex Deucher
2022-05-04 13:48 ` [PATCH 2/2] Revert "fbdev: fbmem: add a helper to determine if an aperture is used by a fw fb" Alex Deucher
2022-05-04 16:48 ` Javier Martinez Canillas
2022-05-04 16:45 ` [PATCH 1/2] Revert "drm/amdgpu: disable runpm if we are the primary adapter" Javier Martinez Canillas
2022-05-04 16:50 ` Alex Deucher
2022-05-04 17:02 ` Javier Martinez Canillas [this message]
2022-05-04 16:47 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd36a5ec-e795-8b60-3a02-b865ef897da2@redhat.com \
--to=javierm@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).