From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675613783DE for ; Fri, 15 May 2026 07:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778829519; cv=none; b=l0qD/8rjrwWU1Fx6+0WdYGnN/ogz2oMFXLfJA4+gKec8mz4d/0JcpQ7H593hnoS7Ho2zpAmdWhyBZCGC67hiZSyy7ZCr7H+hslvttA8fbQJk6rufv+VD4N3h3/vXuECd/TrHk0uBDgHtUZfxc1L6N6o5BvixB4ZilPALQq/dHsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778829519; c=relaxed/simple; bh=s9K4bzfEGDJPSBneSpLXyM7YwAe9heOYXevhGsB2LcQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o+UigNV6ml8a77S2HGomBmUZY/7a9FZ10W66fQKoIIBaZ/9MvkUlQOJvDbqikbTp5W1KRiusf6VcsWDkFtBlMTjIt/q4S6+3bGaJW7vexWZ8qjDoiBWINbib62jMfHTZ8WCqpgI+E4dGJgMokmAWUMqijIXgMdkZsOcqif5kGL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=GGzT5omr; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=4kcGLKwk; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=TOG2UlxT; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=93AeYFZP; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="GGzT5omr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="4kcGLKwk"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="TOG2UlxT"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="93AeYFZP" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C7B326B686; Fri, 15 May 2026 07:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778829517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2urq/YBGfx2kVkjt7rdkKOU9ux8Rtb80wnctCaLJ7q8=; b=GGzT5omrO3PTz+pc7AhbM5oFZkVMInpP0oVq6ScIA+uamu/5yA1RJfWJwLP3IBh7EI7nHe gF4lgQx3zjGHGeYW8hqgbBzR3tjnqcVQJQycnwTtFa0zONodilyrqlhf3o5xhNxGmalO+j ojzZuSsTA2ukdXy/TMH7OYNVs9daQ4Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778829517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2urq/YBGfx2kVkjt7rdkKOU9ux8Rtb80wnctCaLJ7q8=; b=4kcGLKwkngJKqj089FCs9XJKisSACa+MDcFf00yIo68BobIGpl+z7x+5UxEM1GmSnYBKLd nwQFKwjg49Lu+xBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TOG2UlxT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=93AeYFZP DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778829516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2urq/YBGfx2kVkjt7rdkKOU9ux8Rtb80wnctCaLJ7q8=; b=TOG2UlxT8SVdb4QtXqodnfZi2HDkbHJAQ3SHisgK2snxDt6ifUNo35AdjoWuh1aIC/4sAu pnCGDGKQkvFrgBERVTtZyGm/VQn4oVjMOLJBRcOHpINCP+/4CsToKhbqzO3Rg25sVVWLtN RoZabh6p1FQnGLRouRs1vSYh4bhjtFk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778829516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2urq/YBGfx2kVkjt7rdkKOU9ux8Rtb80wnctCaLJ7q8=; b=93AeYFZPB3gSpr4aNF05IWzetyUGM1c4N6nno4KtDT5WLrpUHnGuao9GCBZcXxDz1QuLCM NUuPtwe88tV02yBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4B21D593A9; Fri, 15 May 2026 07:18:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id nrrkEMzIBmq7aQAAD6G6ig (envelope-from ); Fri, 15 May 2026 07:18:36 +0000 Message-ID: Date: Fri, 15 May 2026 09:18:35 +0200 Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/14] fbdev: metronomefb: fix potential memory leak in metronomefb_probe() To: Abdun Nihaal , Helge Deller , Javier Martinez Canillas , Benjamin Herrenschmidt , Andrew Morton , Sebastian Siewior , Florian Tobias Schandinat , Ondrej Zary , Antonino Daplas , Paul Mundt , Krzysztof Helt , Tomi Valkeinen , Michal Januszewski , Heiko Schocher , Peter Jones Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> <20260514-fbdev-v1-3-b3a2474fa720@cse.iitm.ac.in> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260514-fbdev-v1-3-b3a2474fa720@cse.iitm.ac.in> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spam-Score: -4.51 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_TO(0.00)[cse.iitm.ac.in,gmx.de,redhat.com,kernel.crashing.org,linux-foundation.org,linutronix.de,rainbow-software.org,gmail.com,linux-sh.org,wp.pl,ti.com,gentoo.org,denx.de]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[19]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com,gmx.de,wp.pl]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[iitm.ac.in:email,suse.com:url,suse.de:email,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: C7B326B686 X-Spam-Level: Am 14.05.26 um 10:24 schrieb Abdun Nihaal: > The memory allocated for pagerefs in fb_deferred_io_init() is not freed > on the error path. Fix it by calling fb_deferred_io_cleanup(). > > Fixes: 56c134f7f1b5 ("fbdev: Track deferred-I/O pages in pageref struct") > Cc: stable@vger.kernel.org > Signed-off-by: Abdun Nihaal Reviewed-by: Thomas Zimmermann > --- > drivers/video/fbdev/metronomefb.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/metronomefb.c b/drivers/video/fbdev/metronomefb.c > index 6f0942c6e5f1..83c614963a0a 100644 > --- a/drivers/video/fbdev/metronomefb.c > +++ b/drivers/video/fbdev/metronomefb.c > @@ -645,12 +645,14 @@ static int metronomefb_probe(struct platform_device *dev) > info->flags = FBINFO_VIRTFB; > > info->fbdefio = &metronomefb_defio; > - fb_deferred_io_init(info); > + retval = fb_deferred_io_init(info); > + if (retval) > + goto err_free_irq; > > retval = fb_alloc_cmap(&info->cmap, 8, 0); > if (retval < 0) { > dev_err(&dev->dev, "Failed to allocate colormap\n"); > - goto err_free_irq; > + goto err_fbdefio; > } > > /* set cmap */ > @@ -673,6 +675,8 @@ static int metronomefb_probe(struct platform_device *dev) > > err_cmap: > fb_dealloc_cmap(&info->cmap); > +err_fbdefio: > + fb_deferred_io_cleanup(info); > err_free_irq: > board->cleanup(par); > err_csum_table: > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)