From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DFEFEEB594 for ; Wed, 13 Sep 2023 05:13:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230055AbjIMFNt (ORCPT ); Wed, 13 Sep 2023 01:13:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231916AbjIMFNt (ORCPT ); Wed, 13 Sep 2023 01:13:49 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 620901730; Tue, 12 Sep 2023 22:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=wi7sEbnWQkNm+KIFbt3O9vgRJK/F8KR/obeG/emHIA8=; b=mF4o7D1Pwuotid1cqUWyP06EWN wdHk1PWBHmFNgEJj9ir7EfipnECbpCn+2OjcwKU9ut7MzkaurrT0nlKh2M4K0E1YVWQt5kTD1Un0z gKOAHtClUeHNckSh7UbmPTb+ykXCvZqNrS8e0Cy4BadXGmszINThFi8OAs8bS8K0maQNoeqrzQXPH ujZST+qzlif3pqAjOGra+2gG6UCanH9jWre8WT43o+gLiFLuzP7gyd9qwmA7mybIS7YfDKnPdL2+B 15VAtbtaDkd21lFi6jpl4qH5pPNhquNPBBRFJDXNbXAE8impg2scv+4R1j3pwkSv7CWcd4rd7uDWL zoYgc6BA==; Received: from [2601:1c2:980:9ec0::9fed] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qgIBz-004edS-29; Wed, 13 Sep 2023 05:13:35 +0000 Message-ID: Date: Tue, 12 Sep 2023 22:13:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: sh4-linux-ld: drivers/video/fbdev/sh7760fb.o:undefined reference to `fb_io_read' Content-Language: en-US To: kernel test robot , Thomas Zimmermann Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Sam Ravnborg , John Paul Adrian Glaubitz , linux-fbdev@vger.kernel.org References: <202309130632.LS04CPWu-lkp@intel.com> From: Randy Dunlap In-Reply-To: <202309130632.LS04CPWu-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 9/12/23 15:42, kernel test robot wrote: > Hi Thomas, > > FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 3669558bdf354cd352be955ef2764cde6a9bf5ec > commit: 5f86367006c6a0662faaf36f753f437afe42fb63 fbdev/sh7760fb: Use fbdev I/O helpers > date: 6 weeks ago > config: sh-randconfig-r012-20230913 (https://download.01.org/0day-ci/archive/20230913/202309130632.LS04CPWu-lkp@intel.com/config) > compiler: sh4-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230913/202309130632.LS04CPWu-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202309130632.LS04CPWu-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > sh4-linux-ld: drivers/video/fbdev/sh7760fb.o: in function `sh7760fb_probe': > sh7760fb.c:(.text+0x374): undefined reference to `framebuffer_alloc' > sh4-linux-ld: sh7760fb.c:(.text+0x394): undefined reference to `fb_videomode_to_var' > sh4-linux-ld: sh7760fb.c:(.text+0x39c): undefined reference to `fb_alloc_cmap' > sh4-linux-ld: sh7760fb.c:(.text+0x3a4): undefined reference to `register_framebuffer' > sh4-linux-ld: sh7760fb.c:(.text+0x3ac): undefined reference to `fb_dealloc_cmap' > sh4-linux-ld: sh7760fb.c:(.text+0x434): undefined reference to `framebuffer_release' > sh4-linux-ld: drivers/video/fbdev/sh7760fb.o: in function `sh7760fb_remove': > sh7760fb.c:(.text+0x800): undefined reference to `unregister_framebuffer' > sh4-linux-ld: sh7760fb.c:(.text+0x804): undefined reference to `fb_dealloc_cmap' > sh4-linux-ld: sh7760fb.c:(.text+0x814): undefined reference to `framebuffer_release' >>> sh4-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0xc): undefined reference to `fb_io_read' >>> sh4-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x10): undefined reference to `fb_io_write' > sh4-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x2c): undefined reference to `cfb_fillrect' > sh4-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x30): undefined reference to `cfb_copyarea' > sh4-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x34): undefined reference to `cfb_imageblit' The problem is CONFIG_FB=m and CONFIG_FB_SH7760=y. This can be fixed by this simple change ... if it's correct. or this Kconfig entry can be made into a tristate, but that may not help with booting a system. ~~~ diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1762,7 +1762,7 @@ config FB_COBALT config FB_SH7760 bool "SH7760/SH7763/SH7720/SH7721 LCDC support" - depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ + depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721) select FB_IOMEM_HELPERS help -- ~Randy